Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback if no broker found for the specified table name #9914

Merged

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Dec 5, 2022

Try to fix a test failure caused by changes in #9902

Previously, null was provided to DynamicBrokerSelector to get a random broker. With the new changes in #9902 now db.mytable is passed to DynamicBrokerSelector. However, DynamicBrokerSelector has no brokers for the .

formatted name, but it has brokers for mytable.

@klsince klsince force-pushed the fix_testQuerySourceWithDatabaseName branch from ffe1661 to a7c8ae8 Compare December 6, 2022 00:19
@codecov-commenter
Copy link

Codecov Report

Merging #9914 (a7c8ae8) into master (ecf41be) will decrease coverage by 39.33%.
The diff coverage is 69.23%.

@@              Coverage Diff              @@
##             master    #9914       +/-   ##
=============================================
- Coverage     64.30%   24.96%   -39.34%     
+ Complexity     5034       44     -4990     
=============================================
  Files          1928     1969       +41     
  Lines        103874   105997     +2123     
  Branches      15823    16084      +261     
=============================================
- Hits          66793    26466    -40327     
- Misses        32254    76836    +44582     
+ Partials       4827     2695     -2132     
Flag Coverage Δ
integration1 24.96% <69.23%> (?)
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../pinot/common/function/scalar/StringFunctions.java 32.45% <0.00%> (-23.80%) ⬇️
...org/apache/pinot/client/DynamicBrokerSelector.java 77.08% <81.81%> (-13.62%) ⬇️
...in/java/org/apache/pinot/spi/utils/BytesUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/stream/StreamMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1597 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit 7b4cc83 into apache:master Dec 6, 2022
@klsince klsince deleted the fix_testQuerySourceWithDatabaseName branch December 6, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants