Table selector won't work if table name is null

[LaroLuo]

pinot/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java

Lines 86 to 94 in d1d2ddb

	* Executes a query.
	*
	* @param query The query to execute
	* @return The result of the query
	* @throws PinotClientException If an exception occurs while processing the query
	*/
	public ResultSetGroup execute(String query) {
	return execute(null, query);
	}

[Jackie-Jiang]

Thanks for reporting the issue.

If table name is not provided, we should parse the query and extract the table name from the query. This requires pulling in the CalciteSqlParser class, which is currently in pinot-common module.
We can either:

• Make pinot-client depend on pinot-common
• Pull CalciteSqlParser into pinot-spi

cc @xiangfu0

[npawar]

Assuming we are okay with these dependencies in pinot-client @xiangfu0 , labeling this as beginner as it looks straightforward enough to fix. Lmk if it is not.

[tanmesh]

I am planning to pick this up making the pinot-client depend on pinot-common.

[tanmesh]

Hey @npawar @Jackie-Jiang 👋 , can you please assign someone to review this PR 🙏

[xiangfu0]

The PR is on the right track.
One thing worth mentioning is that the get table name is the best effort.
And if the tableName is null, the brokerSelector should return any broker. E.g. select 1 is usually used for testing the db connection by many external systems. This kind of query has no table name, but also a valid query.

[Jackie-Jiang]

Solved with #9902