Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Add op fmax, fmin, fmod #17567

Merged
merged 7 commits into from
Mar 23, 2020
Merged

[Numpy] Add op fmax, fmin, fmod #17567

merged 7 commits into from
Mar 23, 2020

Conversation

hanke580
Copy link
Contributor

@hanke580 hanke580 commented Feb 11, 2020 •
edited
Loading

Description

fmax operator

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Performance comparisons (in microseconds):

Operator Official NumPy Legacy ctypes New ctypes New Cython
fmax 0.52 22.91 15.89 8.13
fmin 0.52 22.92 15.8 8.17
fmod 0.83 23.08 16.01 8.19

@hanke580 hanke580 requested a review from szha as a code owner February 11, 2020 17:28
@hanke580 hanke580 requested a review from haojin2 February 11, 2020 17:30
haojin2
haojin2 reviewed Feb 11, 2020
View reviewed changes
src/operator/mshadow_op.h Outdated Show resolved Hide resolved
@hanke580 hanke580 force-pushed the fmax branch 2 times, most recently from f45b2d8 to 351cce6 Compare February 14, 2020 05:08
@hanke580 hanke580 changed the title [Numpy] Add op fmax [Numpy] Add op fmax, fmin, fmod Feb 14, 2020
@hanke580 hanke580 force-pushed the fmax branch 5 times, most recently from cd9f984 to 7168986 Compare February 18, 2020 15:36
@hanke580 hanke580 force-pushed the fmax branch 6 times, most recently from d81e53c to 6ae14a5 Compare February 25, 2020 03:15
@hanke580 hanke580 force-pushed the fmax branch 2 times, most recently from 7ff5708 to 4061f24 Compare March 10, 2020 04:26
@hanke580 hanke580 force-pushed the fmax branch 2 times, most recently from d87a208 to 0b5e93f Compare March 12, 2020 05:23
@hanke580 hanke580 force-pushed the fmax branch 4 times, most recently from 4547f93 to ab93b2d Compare March 17, 2020 16:31
hzfan
hzfan approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanke580 hanke580 force-pushed the fmax branch 3 times, most recently from a50d245 to af8723d Compare March 18, 2020 04:48
@haojin2 haojin2 merged commit 2f358fd into apache:master Mar 23, 2020
anirudh2290 added a commit to anirudh2290/mxnet that referenced this pull request Mar 27, 2020
@anirudh2290
Merge branch 'master' of https://github.com/apache/incubator-mxnet
ae654ba 
* 'master' of https://github.com/apache/incubator-mxnet: (192 commits)
  * impl - FFI for np einsum (apache#17869)
  [Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789)
  [Numpy] Kron operator (apache#17323)
  cmake: Set DMLC_LOG_FATAL_THROW only for building mxnet and not for tvm (apache#17878)
  Add simplified HybridBlock.forward without F (apache#17530)
  Use FP32 copy of weights for norm (multitensor LAMB optimizer) (apache#17700)
  Use multi-tensor sumSQ in clip_global_norm (apache#17652)
  [Numpy] Add op fmax, fmin, fmod (apache#17567)
  Adding sparse support to MXTensor for custom operators (apache#17569)
  Update 3rdparty/mkldnn to v1.2.2 (apache#17313)
  Dynamic subgraph compile support (apache#17623)
  Refactor cpp-package CMakeLists.txt & add missing inference/imagenet_inference (apache#17835)
  staticbuild: Fix potential user-assisted execution of arbitrary code  (apache#17860)
  * FFI for np.argmax and np.argmin (apache#17843)
  ffi for roll/rot90 (apache#17861)
  Skip test_multi_worker_dataloader_release_pool on OS X (apache#17797)
  add ffi for full_like, binary (apache#17811)
  HybridBlock.export() to return created filenames (apache#17758)
  Fix SoftReLU fused operator numerical stability (apache#17849)
  CI: Test clang10 cpu & gpu builds with -WError (apache#17830)
  ...
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
@hanke580 @MoisesHer
[Numpy] Add op fmax, fmin, fmod (apache#17567)
27f8ba6 
* [Numpy] Add op fmax, fmin

* Fix sanity

* Fix bug of gpu part, add scalar compute

* Finish cpu,gpu test of fmax, fmin

* * Fix 3rd Party

* * Prune redundent alias

* * Add op fmod (rfmod still need check)

* * Fix rfmod function

* * Impl FFI

* * Fix windows oversize by adding files

Co-authored-by: Han <[email protected]>
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@hanke580 @anirudh2290
[Numpy] Add op fmax, fmin, fmod (apache#17567)
808d89d 
* [Numpy] Add op fmax, fmin

* Fix sanity

* Fix bug of gpu part, add scalar compute

* Finish cpu,gpu test of fmax, fmin

* * Fix 3rd Party

* * Prune redundent alias

* * Add op fmod (rfmod still need check)

* * Fix rfmod function

* * Impl FFI

* * Fix windows oversize by adding files

Co-authored-by: Han <[email protected]>
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@hanke580 @sxjscience
[Numpy] Add op fmax, fmin, fmod (apache#17567)
3f195fb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 left review comments

@hzfan hzfan hzfan approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanke580 @haojin2 @hzfan @reminisce