Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot delete multiple plugins without page refreshing #1317

Merged
merged 16 commits into from
Jan 25, 2021
Merged

fix: cannot delete multiple plugins without page refreshing #1317

merged 16 commits into from
Jan 25, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Jan 17, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

resolve #1316
Update the plugin data after deleting a plugin

@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #1317 (ab5b869) into master (754f559) will increase coverage by 18.80%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1317       +/-   ##
===========================================
+ Coverage   44.19%   63.00%   +18.80%     
===========================================
  Files          31       41       +10     
  Lines        1948     2360      +412     
===========================================
+ Hits          861     1487      +626     
+ Misses        975      697      -278     
- Partials      112      176       +64     
Impacted Files Coverage Δ
api/internal/log/zap.go 60.86% <0.00%> (ø)
api/cmd/managerapi.go 77.08% <0.00%> (ø)
...l/handler/route_online_debug/route_online_debug.go 73.80% <0.00%> (ø)
api/internal/core/storage/etcd.go 51.51% <0.00%> (ø)
api/internal/route.go 83.87% <0.00%> (ø)
api/internal/handler/healthz/healthz.go 66.66% <0.00%> (ø)
api/cmd/manager/main.go 0.00% <0.00%> (ø)
api/internal/core/storage/storage_mock.go 0.00% <0.00%> (ø)
api/internal/conf/conf.go 67.85% <0.00%> (ø)
api/internal/log/log.go 50.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754f559...7cc3666. Read the comment docs.

@juzhiyuan
Copy link
Member

@guoqqqi CI failed

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get what?

@juzhiyuan juzhiyuan reopened this Jan 25, 2021
@juzhiyuan juzhiyuan requested review from LiteSun and liuxiran January 25, 2021 03:48
@juzhiyuan juzhiyuan merged commit 1bdcaa8 into apache:master Jan 25, 2021
@juzhiyuan juzhiyuan deleted the fix-globalPlugin branch January 25, 2021 07:02
@juzhiyuan
Copy link
Member

@guoqqqi CI failed

@guoqqqi
Copy link
Member Author

guoqqqi commented Jan 26, 2021

Hi,I will fix it at #1372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GlobalPlugin List: cannot delete multiple plugins without page refreshing
4 participants