fix: CI failed in create-route-with-upstream #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
- Coverage 63.05% 62.71% -0.34%
==========================================
Files 41 41
Lines 2360 2360
==========================================
- Hits 1488 1480 -8
- Misses 697 704 +7
- Partials 175 176 +1
Continue to review full report at Codecov.
|
juzhiyuan
approved these changes
Jan 24, 2021
|
ping @LiteSun |
liuxiran
reviewed
Jan 24, 2021
| @@ -25,6 +25,7 @@ context('Create Route with Upstream', () => { | |||
| description: '#desc', | |||
| upstreamSelector: '#upstream_id', | |||
| searchName: '[title=Name]', | |||
| custom: '[title=Custom]', | |||
There was a problem hiding this comment.
the meaning of custom is not very clear IMHO, it would be better to change a name, e.g: something like select_upstream ^_^
There was a problem hiding this comment.
Thanks, I agree with you
4 tasks
juzhiyuan
approved these changes
Jan 24, 2021
|
@membphis it's here |
liuxiran
approved these changes
Jan 24, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
resolve fix: cannot delete multiple plugins without page refreshing #1317
Bugfix
Description
How to fix?
update domSelect and data