Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot delete multiple plugins without page refreshing #1317

Merged
merged 16 commits into from
Jan 25, 2021
Merged

fix: cannot delete multiple plugins without page refreshing #1317

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0a94c69
fix: cannot delete multiple plugins without page refreshing
guoqqqi Jan 17, 2021
34a272f
add e2e
guoqqqi Jan 17, 2021
00654d6
Deleted change to delete
guoqqqi Jan 17, 2021
bd06d0c
Change to addPlugins function global
guoqqqi Jan 17, 2021
5b3406d
Change json file name
guoqqqi Jan 17, 2021
148fe0f
Use this global function
guoqqqi Jan 17, 2021
ca3cf3b
Receive a parameter cases
guoqqqi Jan 18, 2021
8c5bd66
Update codes, add a comment
guoqqqi Jan 21, 2021
c81a015
Add parameter for this function
guoqqqi Jan 21, 2021
b01d57d
Update schema-smocktest.spec.js
juzhiyuan Jan 22, 2021
b7c7c4f
test: change the public function name
guoqqqi Jan 23, 2021
c9ea15c
test: add commit
guoqqqi Jan 23, 2021
1819bbe
test: delete wait
guoqqqi Jan 24, 2021
ef21238
text: CI error
guoqqqi Jan 24, 2021
ab5b869
test: update code
guoqqqi Jan 24, 2021
7cc3666
Update commands.js
juzhiyuan Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion web/cypress/integration/plugin/create_and_delete_plugin.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ context('Create and Delete Plugin List', () => {
it('should delete plugin list', () => {
cy.visit('/');
cy.contains('Plugin').click();

cy.get(domSelectors.refresh).click();
cy.get(domSelectors.tableCell).then(function (rows) {
[...rows].forEach((row) => {
Expand Down
1 change: 1 addition & 0 deletions web/cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ Cypress.Commands.add('configurePlugins', (cases) => {
});

// NOTE: wait for the Drawer to appear on the DOM
cy.get({ timeout });
cy.get(domSelectors.drawer).within(() => {
cy.get(domSelectors.switch).click({
force: true,
Expand Down