Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitDagBundle to support https (include 46073/46179) #46226

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Jan 29, 2025

related: #45998
This addresses from previous PRs (#46073 , #46179).


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@jx2lee jx2lee changed the title Fix GitDagBundle to support https Fix GitDagBundle to support https (include 46073/46179) Jan 29, 2025
@jx2lee jx2lee marked this pull request as ready for review January 29, 2025 06:26
@jx2lee jx2lee force-pushed the gitbundle-https branch 3 times, most recently from a9cce3f to db2ceac Compare January 29, 2025 13:52
@jx2lee jx2lee requested a review from ephraimbuddy January 29, 2025 13:52
@ephraimbuddy
Copy link
Contributor

ephraimbuddy commented Jan 29, 2025

The failing tests don't seem related...you can rebase the PR

@jx2lee
Copy link
Contributor Author

jx2lee commented Jan 29, 2025

@ephraimbuddy Tests in api_connexion were broken.. related this PR were passed (in my local).

@jx2lee jx2lee force-pushed the gitbundle-https branch 2 times, most recently from 381e248 to 951b5f0 Compare January 29, 2025 16:00
@jedcunningham jedcunningham merged commit 0637366 into apache:main Jan 30, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants