Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support https repos in GitHook #45998

Closed
1 task done
jedcunningham opened this issue Jan 24, 2025 · 1 comment · Fixed by #46073
Closed
1 task done

Support https repos in GitHook #45998

jedcunningham opened this issue Jan 24, 2025 · 1 comment · Fixed by #46073
Assignees
@jx2lee
Labels
AIP-66: DAG Bundle/Manifest kind:feature Feature Requests kind:meta High-level information important to the community

Comments

@jedcunningham
Copy link
Member

Body

We should support pointing at repos via https - both public and private repos using auth tokens. This check in initialize blocks it.

Also, while we are at it, we need to update the example in config.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@jedcunningham jedcunningham added AIP-66: DAG Bundle/Manifest kind:meta High-level information important to the community labels Jan 24, 2025
@dosubot dosubot bot added the kind:feature Feature Requests label Jan 24, 2025
@jx2lee
Copy link
Contributor

jx2lee commented Jan 26, 2025 •
edited
Loading

@jedcunningham Can i take this?
I fixed view_url method to enable https, along with the point you mentioned!

@jx2lee jx2lee mentioned this issue Jan 26, 2025
Merged
This was referenced Jan 28, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jx2lee jx2lee

Labels
AIP-66: DAG Bundle/Manifest kind:feature Feature Requests kind:meta High-level information important to the community
Projects
AIP-66: DAG Bundles & Parsing
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GitDagBundle to support https jx2lee/airflow
2 participants
@jx2lee @jedcunningham