Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitDagBundle to support https #46073

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Jan 26, 2025

closes: #45998


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@jx2lee jx2lee marked this pull request as ready for review January 26, 2025 16:09
@jx2lee jx2lee force-pushed the support-https-repo branch from 8148d88 to 60ef1e6 Compare January 26, 2025 16:51
@jx2lee jx2lee changed the title Fix to enable https in GitDagBundle Fix GitDagBundle to support https Jan 26, 2025
@jedcunningham jedcunningham merged commit a605f04 into apache:main Jan 27, 2025
45 checks passed
@jedcunningham
Copy link
Member

Thanks @jx2lee!

vatsrahul1001 pushed a commit to astronomer/airflow that referenced this pull request Jan 27, 2025
@utkarsharma2 utkarsharma2 added this to the Airflow 3.0.0 milestone Jan 27, 2025
@utkarsharma2 utkarsharma2 added the type:new-feature Changelog: New Features label Jan 27, 2025
potiuk added a commit to potiuk/airflow that referenced this pull request Jan 29, 2025
potiuk added a commit to potiuk/airflow that referenced this pull request Jan 29, 2025
@potiuk
Copy link
Member

potiuk commented Jan 29, 2025

Unfortunately @jx2lee -> you will have to recreate that PR. For the last 2 days we had a change merged that masked failures of tests - and this one actually failed, but got green - it causes failures on our main, so we have to revert it.

Apologies for that!

jedcunningham pushed a commit that referenced this pull request Jan 29, 2025
@jx2lee
Copy link
Contributor Author

jx2lee commented Jan 29, 2025

@potiuk Oh, it's okay! I didn't check the test code properly. I'll create a new PR. Thanks!

@potiuk
Copy link
Member

potiuk commented Jan 29, 2025

@potiuk Oh, it's okay! I didn't check the test code properly. I'll create a new PR. Thanks!

Not your fault. CI should check it and fail

got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Support https repos in GitHook
4 participants