Fix application_file failure when parsing dictionary in SparkKubernetesOperator
#34996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per documentation, it should also accept YAML and JSON directly. The operator is working fine when we pass the file path. But fails when we pass the YAML or JSON as dictionary.
xs2tarunkukreja
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Taragolis
reviewed
Oct 17, 2023
Comment on lines
+114
to
+117
| if isinstance(self.application_file, str): | ||
| body = _load_body_to_dict(self.application_file) | ||
| else: | ||
| body = self.application_file |
There was a problem hiding this comment.
As we discuss previously this changes also required:
| body = _load_body_to_dict(self.application_file) | ||
| else: | ||
| body = self.application_file | ||
|
|
||
| body = _load_body_to_dict(self.application_file) |
There was a problem hiding this comment.
I think this line should be removed, no?
| @@ -111,6 +111,11 @@ def _get_namespace_event_stream(self, namespace, query_kwargs=None): | |||
| raise | |||
|
|
|||
| def execute(self, context: Context): | |||
| if isinstance(self.application_file, str): | |||
There was a problem hiding this comment.
def __init__(
self,
*,
application_file: str,
namespace: str | None = None,The current type is string, if you want to support other types, you need to update the type of this parameter (and its doc.)
eladkal
changed the title
application_file failure when parsing dictionary in SparkKubernetesOperator
|
@xs2tarunkukreja can you adress the comments please? |
|
Fixed in #35848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per documentation, it should also accept YAML and JSON directly. The operator is working fine when we pass the file path. But fails when we pass the YAML or JSON as dictionary.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.