Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application_file failure when parsing dictionary in SparkKubernetesOperator #34996

Closed
wants to merge 1 commit into from
Closed

Fix application_file failure when parsing dictionary in SparkKubernetesOperator #34996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ def _get_namespace_event_stream(self, namespace, query_kwargs=None):
raise

def execute(self, context: Context):
if isinstance(self.application_file, str):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    def __init__(
        self,
        *,
        application_file: str,
        namespace: str | None = None,

The current type is string, if you want to support other types, you need to update the type of this parameter (and its doc.)

body = _load_body_to_dict(self.application_file)
else:
body = self.application_file
Comment on lines +114 to +117
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discuss previously this changes also required:

  1. Change docstring
  2. Write tests https://github.com/apache/airflow/blob/main/tests/providers/cncf/kubernetes/operators/test_spark_kubernetes.py


body = _load_body_to_dict(self.application_file)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line should be removed, no?

name = body["metadata"]["name"]
namespace = self.namespace or self.hook.get_namespace()
Expand Down