ejabberd_user: bug fixes + tests #7033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
ansibullbot
added
needs_ci
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
ci_verified
ansibullbot
removed
the
needs_revision
1 task
felixfontein
added
check-before-release
ansibullbot
added
the
needs_revision
ansibullbot
removed
the
needs_revision
|
If nobody objects, I'll merge this by the end of this week. |
felixfontein
removed
the
check-before-release
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #7069 🤖 @patchback |
|
@russoz thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
* ejabberd_user: bug fixes + tests * fix changed property * add license to handler file * adjustments to test * add needs/target/setup_epel to aliases * further adjustments to integration tests * add target to integration tests * add some skips to test * skip centos as it has no ejabberd * skip fedora as it has no ejabberd * discard unused epel setup * add changelog frag * remove ejabberd before tests * fix typo (cherry picked from commit c1f2f12)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7070 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
* ejabberd_user: bug fixes + tests * fix changed property * add license to handler file * adjustments to test * add needs/target/setup_epel to aliases * further adjustments to integration tests * add target to integration tests * add some skips to test * skip centos as it has no ejabberd * skip fedora as it has no ejabberd * discard unused epel setup * add changelog frag * remove ejabberd before tests * fix typo (cherry picked from commit c1f2f12)
felixfontein
pushed a commit
that referenced
this pull request
Aug 8, 2023
…ts (#7069) ejabberd_user: bug fixes + tests (#7033) * ejabberd_user: bug fixes + tests * fix changed property * add license to handler file * adjustments to test * add needs/target/setup_epel to aliases * further adjustments to integration tests * add target to integration tests * add some skips to test * skip centos as it has no ejabberd * skip fedora as it has no ejabberd * discard unused epel setup * add changelog frag * remove ejabberd before tests * fix typo (cherry picked from commit c1f2f12) Co-authored-by: Alexei Znamensky <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Aug 8, 2023
…ts (#7070) ejabberd_user: bug fixes + tests (#7033) * ejabberd_user: bug fixes + tests * fix changed property * add license to handler file * adjustments to test * add needs/target/setup_epel to aliases * further adjustments to integration tests * add target to integration tests * add some skips to test * skip centos as it has no ejabberd * skip fedora as it has no ejabberd * discard unused epel setup * add changelog frag * remove ejabberd before tests * fix typo (cherry picked from commit c1f2f12) Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add two bugfixes to ejabberd_user module:
EjabberdUser.existshould returnTrueorFalse, but it was returning the tuple from a command execution (alwaysTrueinboolcontext)EjabberdUser.changedshould returnTrueorFalse, but it was returning the tuple from a command execution (alwaysTrueinboolcontext)Added integration tests.
ISSUE TYPE
COMPONENT NAME
ejabberd_user