ejabberd_user: module error 'rc: 1'

[eliteaz]

Summary

Using a simple task to create ejabberd user

    - name: Create xmpp user
      community.general.ejabberd_user:
        host: "test-xmpp.org"
        username: "bot-dev"
        password: "YZSdvce93FbeRopvT5s8vPVvP"

When I create ejabberd user always get an error rc:1

failed: [tvm-prod-test-xmpp01.org] (item={'xmpp_username': 'bot-dev', 'xmpp_password': 'YZSdvce93FbeRopvT5s8vPVvP'}) => {
    "ansible_loop_var": "item",
    "changed": false,
    "item": {
        "xmpp_password": "YZSdvce93FbeRopvT5s8vPVvP",
        "xmpp_username": "bot-dev"
    },
    "rc": 1
}

as module require:
ejabberd configuration file include mod_admin_extra as a module.
and password also stored in clear text

Issue Type

Bug Report

Component Name

ejabberd_user

Ansible Version

$ ansible --version
ansible [core 2.12.5]
python version = 3.8.10 (default, Jun 22 2022, 20:18:18) [GCC 9.4.0]
jinja version = 2.11.3

Community.general Version

$ ansible-galaxy collection list community.general
community.general 5.7.0

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Steps to Reproduce

Expected Results

expect to create user for ejabberd

Actual Results

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibullbot]

Files identified in the description:

• plugins/modules/packaging/language/pipx.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @russoz
click here for bot help

[ansibullbot]

Files identified in the description:

• plugins/modules/web_infrastructure/ejabberd_user.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @privateip
click here for bot help

[eliteaz]

I have made such a changes in a ejabberd_user module

# diff -u ejabberd_user.py /root/.ansible/collections/ansible_collections/community/general/plugins/modules/web_infrastructure/ejabberd_user.py
--- ejabberd_user.py	2022-10-12 17:40:29.447826943 +0300
+++ /root/.ansible/collections/ansible_collections/community/general/plugins/modules/web_infrastructure/ejabberd_user.py	2022-10-12 17:37:56.527302236 +0300
@@ -164,7 +164,7 @@
                 module.fail_json(msg=err, rc=rc)
 
     elif obj.state == 'present':
-        if not obj.exists:
+        if obj.exists:
             if module.check_mode:
                 module.exit_json(changed=True)
             (rc, out, err) = obj.create()
@@ -172,8 +172,8 @@
             if module.check_mode:
                 module.exit_json(changed=True)
             (rc, out, err) = obj.update()
-        if rc is not None and rc != 0:
-            module.fail_json(msg=err, rc=rc)
+#        if rc is not None and rc != 0:
+#            module.fail_json(msg=err, rc=rc)
 
     if rc is None:
         result['changed'] = False

and user creation works properly
so I think that module logic conditionals not working correctly.

[ansibullbot]

Files identified in the description:

• plugins/modules/ejabberd_user.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[nerijus]

I reported it last year - #3093 (comment)

[russoz]

@eliteaz @nerijus please check whether the PR #7033 does the trick.

[russoz]

@eliteaz @nerijus Could you please confirm whether the fix worked? Thanks

needs_info

[nerijus]

Sorry for the delay, just tested - it works OK now.