Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7033/c1f2f126 backport][stable-7] ejabberd_user: bug fixes + tests #7070

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Aug 7, 2023

This is a backport of PR #7033 as merged into main (c1f2f12).

SUMMARY

Add two bugfixes to ejabberd_user module:

  • the EjabberdUser.exist should return True or False, but it was returning the tuple from a command execution (always True in bool context)
  • the EjabberdUser.changed should return True or False, but it was returning the tuple from a command execution (always True in bool context)

Added integration tests.

ISSUE TYPE
  • Bugfix Pull Request
  • Test Pull Request
COMPONENT NAME

ejabberd_user

* ejabberd_user: bug fixes + tests

* fix changed property

* add license to handler file

* adjustments to test

* add needs/target/setup_epel to aliases

* further adjustments to integration tests

* add target to integration tests

* add some skips to test

* skip centos as it has no ejabberd

* skip fedora as it has no ejabberd

* discard unused epel setup

* add changelog frag

* remove ejabberd before tests

* fix typo

(cherry picked from commit c1f2f12)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Aug 7, 2023
@felixfontein felixfontein merged commit 04f3dd2 into stable-7 Aug 8, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-7/c1f2f126cf95b3fde4de454dfc25b5cad7c48554/pr-7033 branch August 8, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants