Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitwarden: Add field to search for all item attributes, instead of on… #5297

Merged
merged 6 commits into from
Oct 1, 2022
Merged

bitwarden: Add field to search for all item attributes, instead of on… #5297

merged 6 commits into from
Oct 1, 2022

Conversation

betuxy
Copy link
Contributor

@betuxy betuxy commented Sep 20, 2022

SUMMARY

As of now, it is only possible to find bitwarden items via their name.
Names however can occur multiple times on different items.
Finding them by alternative attributes like their unique id could resolve this problem

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

bitwarden

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @lungj
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request lookup lookup plugin plugins plugin (any type) labels Sep 20, 2022
@github-actions
Copy link

github-actions bot commented Sep 20, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Sep 21, 2022
felixfontein
felixfontein reviewed Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments.

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 21, 2022
@betuxy
Copy link
Contributor Author

betuxy commented Sep 21, 2022

Thanks for your contribution! I've added some first comments.

@felixfontein thanks!

@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 21, 2022
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Sep 29, 2022
felixfontein
felixfontein approved these changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since it looks like it won't break anything and nobody complained, I'm going to merge this.

@felixfontein felixfontein merged commit 394647d into ansible-collections:main Oct 1, 2022
@patchback
Copy link

patchback bot commented Oct 1, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/394647df84dd50e6893fc63249e8b01ce67863eb/pr-5297

Backported as #5325

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 1, 2022
@felixfontein
Copy link
Collaborator

@betuxy thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Oct 1, 2022
@betuxy @patchback
bitwarden: Add field to search for all item attributes, instead of on… (
798d67f 
#5297)

* bitwarden: Add field to search for all item attributes, instead of only name.

* bitwarden: Add change to changelog.

* bitwarden: Update changelog entry.

* Update changelogs/fragments/5297-bitwarden-add-search-field.yml

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/lookup/bitwarden.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/lookup/bitwarden.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Ole Pannbacker <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 394647d)
@patchback patchback bot mentioned this pull request Oct 1, 2022
Merged
felixfontein pushed a commit that referenced this pull request Oct 1, 2022
@patchback @betuxy
bitwarden: Add field to search for all item attributes, instead of on… (
94ea18f 
#5297) (#5325)

* bitwarden: Add field to search for all item attributes, instead of only name.

* bitwarden: Add change to changelog.

* bitwarden: Update changelog entry.

* Update changelogs/fragments/5297-bitwarden-add-search-field.yml

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/lookup/bitwarden.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/lookup/bitwarden.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Ole Pannbacker <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 394647d)

Co-authored-by: betuxy <[email protected]>
v1v added a commit to v1v/community.general that referenced this pull request Oct 7, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/support-logs
3d0c09d 
* upstream/main: (203 commits)
  Make pfexec become usable for illumos (ansible-collections#3889)
  znode: add options for authentication (ansible-collections#5306)
  keycloak_user_federation: add explanation and example to vendor option (ansible-collections#4893)
  Next expected release is 5.8.0.
  Allow terraform module to specify complex variable structures (ansible-collections#4797)
  Fix ansible-collections#5313: redhat_subscription module is not idempotent when pool_ids (ansible-collections#5319)
  bitwarden: Add field to search for all item attributes, instead of on… (ansible-collections#5297)
  New Module: Keycloak User Rolemapping (ansible-collections#4898)
  chore: Update lxc_container to support py3 (ansible-collections#5304)
  terraform: run `init` with no-color, too (ansible-collections#5147)
  nmcli: fix error when setting previously unset mac address (ansible-collections#5291)
  [feat] proxmox_snap: snapshot containers with configured mountpoints (ansible-collections#5274)
  machinectl: include the success command (ansible-collections#5287)
  Add SetSessionService to redfish_config (ansible-collections#5009)
  locale_gen: fix UbuntuMode (ansible-collections#5282)
  ini_file: fix lint error (ansible-collections#5307)
  netcup_dnsapi: Add timeout paramter (ansible-collections#5301)
  stable-2.14 is now default.
  Add stable-2.14 to CI, adjust to devel version bump (ansible-collections#5298)
  Try to run reuse workflow without explicitly allowing it for new contributors. (ansible-collections#5296)
  ...
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@betuxy @felixfontein
bitwarden: Add field to search for all item attributes, instead of on… (
d4360aa 
ansible-collections#5297)

* bitwarden: Add field to search for all item attributes, instead of only name.

* bitwarden: Add change to changelog.

* bitwarden: Update changelog entry.

* Update changelogs/fragments/5297-bitwarden-add-search-field.yml

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/lookup/bitwarden.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/lookup/bitwarden.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Ole Pannbacker <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request lookup lookup plugin plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betuxy @ansibullbot @felixfontein