chore: Update lxc_container to support py3 #5304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
russoz
reviewed
Sep 25, 2022
There was a problem hiding this comment.
hi @cloudnull just a couple of minor comments.
You might want to review the documentations for the module and apply
https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#linking-and-other-format-macros-within-module-documentation
felixfontein
added
check-before-release
|
Please also add a changelog fragment :) Thanks. |
This change is mostly just a documentation change which will report the requirements correctly for python3-lxc. I've also removed the use of six which results in us changing `xrange` to `range`. Resolves: ansible-collections#5294 Signed-off-by: Kevin Carter <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]>
cloudnull
force-pushed
the
python3-lxc
branch
from
b8f8ef9 to
94229b4
Compare
done. |
|
Thank you for the review @russoz @felixfontein I've pushed a couple updates and squashed the commits. If you have a moment to re-review it would be greatly appreciated. |
ansibullbot
added
the
needs_revision
russoz
approved these changes
Sep 29, 2022
Co-authored-by: Alexei Znamensky <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
removed
ci_verified
felixfontein
approved these changes
Oct 1, 2022
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change is mostly just a documentation change which will report the requirements correctly for python3-lxc. I've also removed the use of six which results in us changing
xrangetorange.Fixes: #5294
ISSUE TYPE
COMPONENT NAME
lxc_container
Signed-off-by: Kevin Carter [email protected]