-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform: run init
with no-color, too
#5147
terraform: run init
with no-color, too
#5147
Conversation
When running `terraform init` fails, it would output ansi color sequences, making the output hard to read. Maybe setting TF_IN_AUTOMATION would also be beneficial: https://www.terraform.io/cli/config/environment-variables#tf_in_automation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Could you please add a changelog fragment? Thanks.
Also a question: does it make sense to pass that flag only here, and nowhere else? Also, is this flag supported by all versions of terraform?
Current terraform indeed has I don't know when this parameter was introduced, https://www.terraform.io/cli/v1.1.x/commands/init and the current 1.2 have it without version notice. S/o would have to look that up. |
The test
|
@azrdev ping? needs_info |
ecae01c
to
c45f95a
Compare
@felixfontein changed as proposed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If nobody complains, I'll merge in a couple of days.
SUMMARY
When running
terraform init
fails, it would output ansi color sequences, making the output hard to read.Maybe setting TF_IN_AUTOMATION would also be beneficial: https://www.terraform.io/cli/config/environment-variables#tf_in_automation
ISSUE TYPE
COMPONENT NAME
terraform
ADDITIONAL INFORMATION