Switch the auto advance feature to use the settings in the deck options

[abdnh]

Purpose / Description

This switches the auto advance feature to use the shared settings in the deck options.

Fixes

• Ref: Anki Upstream 23.12 Followup Enhancements #15167

Approach

• The code was changed to use the secondsToShowQuestion and secondsToShowAnswer deck config properties. AnkiDroid-specific preference/config values are no longer used, except for the timeoutAnswer preference used to toggle the feature (The computer version requires the user to explicitly toggle it on in every review session - see Add auto-advance options to deck preset ankitects/anki#2765 (review)).
• The preferences to set the timeouts and answer action were removed.
• The "Wait for audio" option didn't exist in the AnkiDroid implementation (the default was to always wait), so it was added.

Before

After

How Has This Been Tested?

Manual testing in the emulator.

Learning (optional, can help others)

Refer to ankitects/anki#2765

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

Issues

• 'Answer Easy' is not available in the computer version. @dae I assume this is intentional? (UPDATE: found this post in the forums)

[github-actions]

Message to maintainers, this PR contains strings changes.

1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

• localization-administration
• download-localized-strings

[abdnh]

Do we need to add a new string so that translators get notified? That's the case for Pontoon. Not sure about Crowdin.

[BrayanDSO]

yep, this only changes the english translation. Change the string key to trigger translations everywhere

[abdnh]

I'm getting random errors like this while running unit tests locally using ./gradlew jacocoUnitTestReport:

java.io.IOException: Unable to create parent directories of C:\Users\Abdo\AppData\Local\Temp\6172405558266228753\org\robolectric\android-all-instrumented\13-robolectric-9030017-i4\android-all-instrumented-13-robolectric-9030
017-i4.jar
            at com.google.common.io.Files.createParentDirs(Files.java:479)
            at org.robolectric.internal.dependency.MavenArtifactFetcher.createArtifactSubdirectory(MavenArtifactFetcher.java:172)
            at org.robolectric.internal.dependency.MavenArtifactFetcher.fetchArtifact(MavenArtifactFetcher.java:73)
            ... 76 more

UPDATE: fixed by running ./gradlew robolectricSdkDownload

[dae]

Making it consistent with the other clients might be better in the long term, but that's perhaps better done in a future PR, as it will require some work to shift from the current automatic always-on approach to an action that toggles it on/off.

Edit: sorry, looks like I replied to a deleted comment.

[BrayanDSO]

Edit: sorry, looks like I replied to a deleted comment.

If this were about my comment, I asked if it wouldn't be better to remove the global option to keep it consistent with the desktop version. But I came to the same conclusion of Damien and deleted my comment minutes later

[BrayanDSO]

LGTM. Thanks a lot

[david-allison]

nit/non-blocking: better to inline this in he callers using with the constant from libAnki

[david-allison]

@abdnh happy with a squash-merge The pull request currently requires maintainers to "Squash Merge" here, or want to rebase so all commits compile and we can rebase merge?

Blocked on Strings

[abdnh]

Let's go with a squash merge.

[BrayanDSO]

Strings merged. Pending squash @david-allison

[david-allison]

Perfect, thanks all!

• Updated strings from Crowdin 2024/01/20 14:22 #15276

[github-actions]

Hi there @abdnh! This is the OpenCollective Notice for PRs merged from 2024-01-01 through 2024-01-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!