-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-advance options to deck preset #2765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Sorry, I forgot to mention one thing about how this should work: there should be a menu action that toggles auto-advance, so it doesn't happen until the user explicitly starts it. Its value shouldn't be saved, so it should always start off. The primary reason for this is that the congratulations page will switch back to review when the day rolls over, and users won't want to wake up to find all their cards have already been answered. :-)
qt/aqt/reviewer.py
Outdated
timer = None | ||
|
||
if conf["secondsToShowAnswer"]: | ||
timer = self._show_answer_timer = self.mw.progress.timer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason you didn't use single_shot() here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to compare the timers so that we make sure a previous card's timer doesn't get to execute on the next card.
That's a feature I'd love to use 😂 |
Couple of remaining issues:
|
(in case it wasn't clear, I'm planning to skip over this for the 23.10 release, so there's no time pressure on this) |
Thanks Abdo. I might need to hold off on this for a week or two, so we can get a hotfix update out first. |
Closes #2645