fix(expansion-panel): don't handle enter/space if modifier is pressed #13790

crisbeto · 2018-10-24T15:09:08Z

Doesn't preventDefault and handle the enter and space key presses if the user is pressing any of the modifier keys.

Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys. Fixes angular#13783.

jelbourn

LGTM

jelbourn · 2018-10-24T18:04:55Z

src/lib/expansion/expansion-panel-header.ts

@@ -140,8 +140,11 @@ export class MatExpansionPanelHeader implements OnDestroy, FocusableOption {
      // Toggle for space and enter keys.
      case SPACE:
      case ENTER:
-        event.preventDefault();
-        this._toggle();
+        if (!event.altKey && !event.metaKey && !event.shiftKey && !event.ctrlKey) {


Not in this PR, but we should think about adding some helper functions to cdk/keycodes for checking stuff like this

Along the same lines as angular#13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.

…#13790) Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys. Fixes #13783.

…13827) Along the same lines as #13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

…angular#13790) Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys. Fixes angular#13783.

…ngular#13827) Along the same lines as angular#13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.

…13827) Along the same lines as #13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.

Based off of the conversation in #13790, these changes add some utilities for dealing with modifier keys on keyboard events.

angular-automatic-lock-bot · 2019-09-10T00:02:24Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

fix(expansion-panel): don't handle enter/space if modifier is pressed

aaca950

Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys. Fixes angular#13783.

crisbeto added the target: patch This PR is targeted for the next patch release label Oct 24, 2018

crisbeto assigned josephperrott Oct 24, 2018

crisbeto requested review from devversion, jelbourn and josephperrott as code owners October 24, 2018 15:09

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 24, 2018

jelbourn approved these changes Oct 24, 2018

View reviewed changes

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018

mmalerba merged commit 04716b1 into angular:master Oct 25, 2018

crisbeto mentioned this pull request Oct 26, 2018

fix(stepper): don't handle enter/space when modifier key is pressed #13827

Merged

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 1, 2018

refactor(keycodes): add utilities for checking modifier keys

67c1142

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto mentioned this pull request Nov 1, 2018

feat(keycodes): add utilities for checking modifier keys #13933

Merged

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 1, 2018

refactor(keycodes): add utilities for checking modifier keys

686af5b

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 1, 2018

refactor(keycodes): add utilities for checking modifier keys

d177b56

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 1, 2018

refactor(keycodes): add utilities for checking modifier keys

a4e5487

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 2, 2018

feat(keycodes): add utilities for checking modifier keys

b775035

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018

feat(keycodes): add utilities for checking modifier keys

dde7d56

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018

feat(keycodes): add utilities for checking modifier keys

77ed3fd

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018

feat(keycodes): add utilities for checking modifier keys

5e4b368

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018

feat(keycodes): add utilities for checking modifier keys

98ad3ae

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018

feat(keycodes): add utilities for checking modifier keys

afc33bb

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018

feat(keycodes): add utilities for checking modifier keys

d87603a

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018

feat(keycodes): add utilities for checking modifier keys

c1e35cc

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018

feat(keycodes): add utilities for checking modifier keys

b3d65f4

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018

feat(keycodes): add utilities for checking modifier keys

3e4ea4e

Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.

vivian-hu-zz pushed a commit that referenced this pull request Nov 6, 2018

feat(keycodes): add utilities for checking modifier keys

4e5f42a

Based off of the conversation in #13790, these changes add some utilities for dealing with modifier keys on keyboard events.

vivian-hu-zz pushed a commit that referenced this pull request Nov 7, 2018

feat(keycodes): add utilities for checking modifier keys (#13933)

7899863

Based off of the conversation in #13790, these changes add some utilities for dealing with modifier keys on keyboard events.

josephperrott pushed a commit that referenced this pull request Nov 20, 2018

feat(keycodes): add utilities for checking modifier keys (#13933)

41f1c9d

Based off of the conversation in #13790, these changes add some utilities for dealing with modifier keys on keyboard events.

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(expansion-panel): don't handle enter/space if modifier is pressed #13790

fix(expansion-panel): don't handle enter/space if modifier is pressed #13790

crisbeto commented Oct 24, 2018

jelbourn left a comment

jelbourn Oct 24, 2018

angular-automatic-lock-bot bot commented Sep 10, 2019

fix(expansion-panel): don't handle enter/space if modifier is pressed #13790

fix(expansion-panel): don't handle enter/space if modifier is pressed #13790

Conversation

crisbeto commented Oct 24, 2018

jelbourn left a comment

Choose a reason for hiding this comment

jelbourn Oct 24, 2018

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 10, 2019