forked from angular/components
-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(keycodes): add utilities for checking modifier keys
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
- Loading branch information
Showing
6 changed files
with
98 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,23 @@ | ||
package(default_visibility=["//visibility:public"]) | ||
|
||
load("//tools:defaults.bzl", "ts_library") | ||
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite") | ||
|
||
ts_library( | ||
ng_module( | ||
name = "keycodes", | ||
module_name = "@angular/cdk/keycodes", | ||
srcs = glob(["**/*.ts"], exclude=["**/*.spec.ts"]), | ||
deps = ["@npm//tslib"], | ||
) | ||
|
||
ng_test_library( | ||
name = "keycodes_test_sources", | ||
srcs = glob(["**/*.spec.ts"]), | ||
deps = [ | ||
"//src/cdk/testing", | ||
":keycodes", | ||
] | ||
) | ||
|
||
ng_web_test_suite( | ||
name = "unit_tests", | ||
deps = [":keycodes_test_sources"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import {createKeyboardEvent} from '@angular/cdk/testing'; | ||
import {hasModifierKey} from './modifiers'; | ||
|
||
describe('keyboard modifiers', () => { | ||
it('should check whether the alt key is pressed', () => { | ||
const event = createKeyboardEvent('keydown', 0); | ||
|
||
expect(hasModifierKey(event)).toBe(false); | ||
Object.defineProperty(event, 'altKey', {get: () => true}); | ||
expect(hasModifierKey(event)).toBe(true); | ||
}); | ||
|
||
it('should check whether the shift key is pressed', () => { | ||
const event = createKeyboardEvent('keydown', 0); | ||
|
||
expect(hasModifierKey(event)).toBe(false); | ||
Object.defineProperty(event, 'shiftKey', {get: () => true}); | ||
expect(hasModifierKey(event)).toBe(true); | ||
}); | ||
|
||
it('should check whether the meta key is pressed', () => { | ||
const event = createKeyboardEvent('keydown', 0); | ||
|
||
expect(hasModifierKey(event)).toBe(false); | ||
Object.defineProperty(event, 'metaKey', {get: () => true}); | ||
expect(hasModifierKey(event)).toBe(true); | ||
}); | ||
|
||
it('should check whether the ctrl key is pressed', () => { | ||
const event = createKeyboardEvent('keydown', 0); | ||
|
||
expect(hasModifierKey(event)).toBe(false); | ||
Object.defineProperty(event, 'ctrlKey', {get: () => true}); | ||
expect(hasModifierKey(event)).toBe(true); | ||
}); | ||
|
||
it('should check if a particular modifier key is pressed', () => { | ||
const event = createKeyboardEvent('keydown', 0); | ||
Object.defineProperty(event, 'ctrlKey', {get: () => true}); | ||
|
||
expect(hasModifierKey(event, 'altKey')).toBe(false); | ||
Object.defineProperty(event, 'altKey', {get: () => true}); | ||
expect(hasModifierKey(event, 'altKey')).toBe(true); | ||
}); | ||
|
||
it('should check if multiple specific modifier keys are pressed', () => { | ||
const event = createKeyboardEvent('keydown', 0); | ||
Object.defineProperty(event, 'ctrlKey', {get: () => true}); | ||
|
||
expect(hasModifierKey(event, 'altKey', 'shiftKey')).toBe(false); | ||
Object.defineProperty(event, 'altKey', {get: () => true}); | ||
Object.defineProperty(event, 'shiftKey', {get: () => true}); | ||
expect(hasModifierKey(event, 'altKey', 'shiftKey')).toBe(true); | ||
}); | ||
|
||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
|
||
type ModifierKey = 'altKey' | 'shiftKey' | 'ctrlKey' | 'metaKey'; | ||
|
||
/** | ||
* Checks whether a modifier key is pressed. | ||
* @param event Event to be checked. | ||
*/ | ||
export function hasModifierKey(event: KeyboardEvent, ...modifiers: ModifierKey[]): boolean { | ||
if (modifiers.length) { | ||
return modifiers.some(modifier => event[modifier]); | ||
} | ||
|
||
return event.altKey || event.shiftKey || event.ctrlKey || event.metaKey; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ | |
*/ | ||
|
||
export * from './keycodes'; | ||
export * from './modifiers'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters