Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not toggle expansion panel on Enter or Space if Ctrl is pressed #13783

Closed
AlexKichkailo opened this issue Oct 24, 2018 · 1 comment · Fixed by #13790
Closed

Do not toggle expansion panel on Enter or Space if Ctrl is pressed #13783

AlexKichkailo opened this issue Oct 24, 2018 · 1 comment · Fixed by #13790
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@AlexKichkailo
Copy link

Bug, feature request, or proposal:

Proposal

What is the expected behavior?

ctrl + enter does not toggle expansion panel

What is the current behavior?

ctrl + enter toggles expansion panel

What is the use-case or motivation for changing an existing behavior?

Ability to implement global shortcuts for the application which often use the Ctrl key

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

angular 7.0.0, material 7.0.0
@crisbeto crisbeto self-assigned this Oct 24, 2018
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Oct 24, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 24, 2018
@crisbeto
fix(expansion-panel): don't handle enter/space if modifier is pressed
aaca950 
Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys.

Fixes angular#13783.
@crisbeto crisbeto mentioned this issue Oct 24, 2018
Merged
mmalerba pushed a commit that referenced this issue Oct 25, 2018
@crisbeto @mmalerba
fix(expansion-panel): don't handle enter/space if modifier is pressed (…
04716b1 
…#13790)

Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys.

Fixes #13783.
mmalerba pushed a commit that referenced this issue Oct 26, 2018
@crisbeto @mmalerba
fix(expansion-panel): don't handle enter/space if modifier is pressed (…
3e6cc77 
…#13790)

Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys.

Fixes #13783.
atscott pushed a commit to atscott/components that referenced this issue Nov 5, 2018
@crisbeto @atscott
fix(expansion-panel): don't handle enter/space if modifier is pressed (…
49f7a50 
…angular#13790)

Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys.

Fixes angular#13783.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(expansion-panel): don't handle enter/space if modifier is pressed crisbeto/material2
2 participants
@crisbeto @AlexKichkailo