Resolve 'bytes'/'binary' discrepancy #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Nov 15, 2024
.github/workflows/main.yaml
Outdated
Comment on lines
6
to
11
| branches: | ||
| # Branches from forks have the form 'user:branch-name' so we only run this job on pull_request events for | ||
| # branches that look like fork branches. Without this we would end up running this job twice for non-forked | ||
| # PRs, once for the push and then once for opening the PR. | ||
| # Taken from https://github.jparrowsec.cnmunity/t/how-to-trigger-an-action-on-push-or-pull-request-but-not-both/16662/10 | ||
| - '**:**' |
There was a problem hiding this comment.
Why is this no longer needed?
There was a problem hiding this comment.
I don't know if something like this is no longer needed. Merging this might cause the workflow to be run twice, but without this change, I wasn't getting it to run as part of the PR checks. Overall, though, this is a cheap/quick workflow, so I'm not too concerned.
tgregg
approved these changes
Nov 18, 2024
|
@toddjonker, I've got two approvals. I'm going to merge this, but if you have any concerns we can revisit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Follow up to #126
Description of changes:
bytesas a fragment keyword in favor ofbinarybytesto be a general purpose input fragment because if we're combining fragments, we need to know what the intended format is to be. Ifbytescould represent binary or text, then something like(ivm 1 1) (bytes ...)would be ambiguous w.r.t. whether the IVM fragment should be converted toE0 01 01 EAor$ion_1_1.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.