Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds conformance DSL syntax check #126

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

popematt
Copy link
Contributor

Issue #, if available:

None

Description of changes:

Adds a CI check for the conformance test DSL.

Still TODO—decide whether we want to use binary or bytes. My preference is binary since it refers to the binary encoding, the conformance DSL grammar in the README file uses binary, but I think most or all of the tests use bytes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jobarr-amzn jobarr-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to simplify the ISL somehow?

check-syntax Show resolved Hide resolved
Co-authored-by: Joshua Barr <[email protected]>
@popematt
Copy link
Contributor Author

Is it possible to simplify the ISL somehow?

Simplify in what sort of way? There are trade offs. Fewer type definitions? DRY it up more? Flatten nested types?

@popematt popematt merged commit 8618604 into amazon-ion:main Oct 30, 2024
@toddjonker
Copy link
Contributor

I think the byte-input form should be able to represent text as well as binary Ion data, so we can verify UTF-8 handling, BOM, etc. In other words, I think the term should be the more general bytes

@popematt
Copy link
Contributor Author

I think the byte-input form should be able to represent text as well as binary Ion data, so we can verify UTF-8 handling, BOM, etc. In other words, I think the term should be the more general bytes

I realize that maybe I was not clear in my initial comments. I was referring to the keyword for the Ion binary fragment form. One of the motivations for adding this ISL grammar is because we've had inconsistent use of (binary ... and (bytes ... for Ion binary fragments. (This ISL grammar was implemented to allow both because of that, but we need to make a decision and clean it up one way or the other.)

Are you saying that the Ion binary fragment form should in fact be a more general "bytes" that is usable for text data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants