Skip to content

Commit

Permalink
Resolve 'bytes'/'binary' discrepancy (#129)
Browse files Browse the repository at this point in the history
  • Loading branch information
popematt authored Nov 19, 2024
1 parent a0acfb4 commit 0b5d57a
Show file tree
Hide file tree
Showing 5 changed files with 184 additions and 173 deletions.
9 changes: 6 additions & 3 deletions conformance/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ test ::= "(" "document" name-string? fragment* continuation ")"
name-string ::= string
fragment ::= "(" "text" string* ")"
fragment ::= "(" "text" text_input* ")"
| "(" "binary" bytes* ")"
| "(" "ivm" int int ")"
| "(" "toplevel" ast* ")"
Expand All @@ -680,8 +680,11 @@ extension ::= "(" "then" name-string? fragment* continuation ")"
each-branch ::= name-string? fragment
bytes ::= int // In the range 0..255
| string // Containing hexadecimal digit pairs with optional whitespace
text_input ::= int // In the range 0..255
| string
bytes ::= int // In the range 0..255
| string // Containing hexadecimal digit pairs with optional whitespace
```

TODO: Explain `ast`
Expand Down
6 changes: 3 additions & 3 deletions conformance/core/empty_document.ion
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@

// With empty fragments

(ion_1_0 (bytes) (produces))
(ion_1_1 (bytes) (produces))
(ion_1_x (bytes) (produces))
(ion_1_0 (binary) (produces))
(ion_1_1 (binary) (produces))
(ion_1_x (binary) (produces))

(document (text) (produces))
(ion_1_0 (text) (produces))
Expand Down
Loading

0 comments on commit 0b5d57a

Please sign in to comment.