Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up individual component CSS loading #6213

Merged
merged 6 commits into from
Mar 6, 2023

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Nov 30, 2022

What

Changes to load component and view style sheets only required by the page being viewed. For example, CSS for the radio buttons only loads on the radio button question page.

Why

This reduces the amount of CSS required for each page and increases the ability of a browser to cache the stylesheets - this should mean a faster load time for both first time and repeat visitors.

See RFC #149 for more details.

Visual changes

None

Anything else

@jon-kirwan jon-kirwan added the DO NOT MERGE Needs further approval before release label Nov 30, 2022
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 November 30, 2022 14:54 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from f464582 to 103a4d0 Compare December 1, 2022 09:32
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 1, 2022 09:32 Inactive
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 1, 2022 11:35 Inactive
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 2, 2022 09:44 Inactive
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 2, 2022 10:17 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from 99583fc to 0e8ebd6 Compare December 2, 2022 12:07
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 2, 2022 12:07 Inactive
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 14, 2022 16:19 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from ff84bc7 to 89748c0 Compare December 14, 2022 16:24
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 14, 2022 16:24 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from 89748c0 to 6eb1a11 Compare December 14, 2022 18:26
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 14, 2022 18:26 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from 6eb1a11 to 4c15b55 Compare December 15, 2022 09:51
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 15, 2022 09:52 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from 4c15b55 to a4498e2 Compare December 15, 2022 12:11
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 15, 2022 12:11 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from a4498e2 to 48813fc Compare December 15, 2022 12:19
@govuk-ci govuk-ci had a problem deploying to smart-answers-pr-6213 December 15, 2022 12:20 Failure
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from 48813fc to e48fffe Compare December 15, 2022 13:40
@govuk-ci govuk-ci had a problem deploying to smart-answers-pr-6213 December 15, 2022 13:41 Failure
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from e48fffe to 7b5de54 Compare December 15, 2022 15:17
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 15, 2022 15:17 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from 7b5de54 to cd085c0 Compare December 15, 2022 16:05
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 15, 2022 16:06 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from cd085c0 to 1e2faba Compare December 15, 2022 16:13
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 15, 2022 16:14 Inactive
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 December 15, 2022 16:36 Inactive
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from 6060f56 to 649998f Compare December 16, 2022 11:26
@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from bc2e36f to b6c7334 Compare March 3, 2023 14:28
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 March 3, 2023 14:28 Inactive
@jon-kirwan jon-kirwan requested a review from MartinJJones March 3, 2023 14:29
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

@jon-kirwan jon-kirwan force-pushed the set-up-individual-component-css branch from b6c7334 to d58494f Compare March 6, 2023 10:06
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6213 March 6, 2023 10:06 Inactive
@jon-kirwan jon-kirwan removed the DO NOT MERGE Needs further approval before release label Mar 6, 2023
@jon-kirwan jon-kirwan changed the title 🚧 [DO NOT MERGE] Set up individual component CSS loading Set up individual component CSS loading Mar 6, 2023
@jon-kirwan jon-kirwan merged commit 3bc4705 into main Mar 6, 2023
@jon-kirwan jon-kirwan deleted the set-up-individual-component-css branch March 6, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants