-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up individual component CSS loading #6213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 1, 2022 09:32
f464582
to
103a4d0
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 2, 2022 12:07
99583fc
to
0e8ebd6
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 14, 2022 16:24
ff84bc7
to
89748c0
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 14, 2022 18:26
89748c0
to
6eb1a11
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 15, 2022 09:51
6eb1a11
to
4c15b55
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 15, 2022 12:11
4c15b55
to
a4498e2
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 15, 2022 12:19
a4498e2
to
48813fc
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 15, 2022 13:40
48813fc
to
e48fffe
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 15, 2022 15:17
e48fffe
to
7b5de54
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 15, 2022 16:05
7b5de54
to
cd085c0
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 15, 2022 16:13
cd085c0
to
1e2faba
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
December 16, 2022 11:26
6060f56
to
649998f
Compare
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
March 3, 2023 14:28
bc2e36f
to
b6c7334
Compare
MartinJJones
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me 👍
jon-kirwan
force-pushed
the
set-up-individual-component-css
branch
from
March 6, 2023 10:06
b6c7334
to
d58494f
Compare
jon-kirwan
changed the title
🚧 [DO NOT MERGE] Set up individual component CSS loading
Set up individual component CSS loading
Mar 6, 2023
This was referenced Mar 14, 2023
This was referenced Apr 18, 2023
This was referenced Apr 27, 2023
Move service manual guide modules alongside respective view styles
alphagov/government-frontend#2759
Merged
This was referenced May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes to load component and view style sheets only required by the page being viewed. For example, CSS for the radio buttons only loads on the radio button question page.
Why
This reduces the amount of CSS required for each page and increases the ability of a browser to cache the stylesheets - this should mean a faster load time for both first time and repeat visitors.
See RFC #149 for more details.
Visual changes
None
Anything else