Skip to content

Commit

Permalink
Temp - add app component styles
Browse files Browse the repository at this point in the history
  • Loading branch information
jon-kirwan committed Dec 2, 2022
1 parent 4ed99a1 commit 0e8ebd6
Show file tree
Hide file tree
Showing 11 changed files with 39 additions and 28 deletions.
9 changes: 5 additions & 4 deletions app/assets/config/manifest.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
//= link application.css
//= link print.css
//= link govuk_publishing_components/components/_radio.css
//= link govuk_publishing_components/components/_date-input.css
//= link govuk_publishing_components/components/_fieldset.css
//= link govuk_publishing_components/components/_summary-list.css

//= link components/_result-card.css
//= link components/_result-item.css
//= link components/_result-sections.css

//= link visualise.css
//= link joint.css
//= link application.js
Expand Down
6 changes: 3 additions & 3 deletions app/assets/stylesheets/application.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ $govuk-include-default-font-face: false;
// @import "govuk_publishing_components/components/warning-text";

@import "components/autocomplete";
@import "components/result-card";
@import "components/result-item";
@import "components/result-sections";
// @import "components/result-card";
// @import "components/result-item";
// @import "components/result-sections";
// @import "smart_answers";

.desktop-min-height {
Expand Down
2 changes: 2 additions & 0 deletions app/assets/stylesheets/components/_result-card.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import "govuk_publishing_components/govuk_frontend_support";

.app-c-result-card {
position: relative;
padding: govuk-spacing(5) govuk-spacing(4);
Expand Down
2 changes: 2 additions & 0 deletions app/assets/stylesheets/components/_result-item.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import "govuk_publishing_components/govuk_frontend_support";

.app-c-result-item {
@include govuk-font($size: 19);
padding-top: govuk-spacing(6);
Expand Down
2 changes: 2 additions & 0 deletions app/assets/stylesheets/components/_result-sections.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import "govuk_publishing_components/govuk_frontend_support";

.app-c-result-sections {
margin-bottom: govuk-spacing(7) * 2;
}
Expand Down
20 changes: 12 additions & 8 deletions app/controllers/application_controller.rb
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
class ApplicationController < ActionController::Base
include Slimmer::Template

before_action do
begin
@individual_stylesheets = GovukPublishingComponents::AppHelpers::AssetHelper.new
rescue NameError
logger.warn("The version of the components gem being used doesn't support individual asset loading.")
end
end

rescue_from GdsApi::TimedOutException, with: :error_503
rescue_from GdsApi::HTTPForbidden, with: :error_403
rescue_from ActionController::UnknownFormat, with: :error_404
Expand All @@ -23,6 +15,18 @@ class ApplicationController < ActionController::Base

slimmer_template :gem_layout

before_action do
puts "HERE"
begin
puts "HERE 2"
@individual_stylesheets = GovukPublishingComponents::AppHelpers::AssetHelper.new
puts @individual_stylesheets
puts "HERE 3"
rescue NameError
logger.warn("The version of the components gem being used doesn't support individual asset loading.")
end
end

protected

def debug?
Expand Down
3 changes: 3 additions & 0 deletions app/views/components/_result-card.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<%= debug(@individual_stylesheets) %>
<% @individual_stylesheets.add_component("result-card") if @individual_stylesheets %>

<%
title ||= nil
description ||= nil
Expand Down
3 changes: 3 additions & 0 deletions app/views/components/_result-item.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<%= debug(@individual_stylesheets) %>
<% @individual_stylesheets.add_component("result-item") if @individual_stylesheets %>

<%
title ||= nil
url ||= nil
Expand Down
3 changes: 3 additions & 0 deletions app/views/components/_result-sections.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<%= debug(@individual_stylesheets) %>
<% @individual_stylesheets.add_component("result-sections") if @individual_stylesheets %>

<%
highlighted ||= true
group_index ||= 1
Expand Down
3 changes: 3 additions & 0 deletions app/views/components/check_uk_visa/_result-card.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<%= debug(@individual_stylesheets) %>
<% @individual_stylesheets.add_component("result-card") if @individual_stylesheets %>

<%
type ||= nil
title ||= nil
Expand Down
14 changes: 1 addition & 13 deletions app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -43,24 +43,12 @@
<meta name="govuk:section" content="<%= @meta_section %>">
<% end %>

<%
# puts "1"
# puts @individual_stylesheets.inspect
# if defined? @individual_stylesheets
# puts "2"
# @individual_stylesheets.get_stylesheets.map do |component|
# puts "component".upcase!
# puts component
# end
# end
%>
<%=
if defined? @individual_stylesheets
puts "@individual_stylesheets".upcase!
puts @individual_stylesheets.inspect
list_of_stylesheets = @individual_stylesheets.get_stylesheets.map do | component |
puts "component"
puts component
puts "component:".upcase! + component
stylesheet_link_tag(component, integrity: false)
end
raw(list_of_stylesheets.join(""))
Expand Down

0 comments on commit 0e8ebd6

Please sign in to comment.