Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace consultation view styles with Design System styles #2750

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

jon-kirwan
Copy link
Contributor

What

https://trello.com/c/fc41oyEK/1923-enable-individual-loading-of-stylesheets-in-government-frontend

Remove unused consultation view stylesheets as a pre-requisite to implementing the AssetHelper to load component and view style sheets only required on the page being viewed.

Why

So there will be less document types to be reviewed and updated when implementing the helper.

Visual changes

None

Anything else

@jon-kirwan jon-kirwan requested a review from MartinJJones April 20, 2023 10:30
@govuk-ci govuk-ci had a problem deploying to government-frontend-pr-2750 April 20, 2023 10:30 Failure
@jon-kirwan jon-kirwan force-pushed the remove-unused-page-view-stylesheet branch from 4aa8638 to 54b3ea5 Compare April 20, 2023 10:32
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2750 April 20, 2023 10:32 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-unused-page-view-stylesheet branch from 54b3ea5 to 3f71a5b Compare April 20, 2023 13:17
@jon-kirwan jon-kirwan requested a review from MartinJJones April 20, 2023 13:23
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jon-kirwan jon-kirwan force-pushed the remove-unused-page-view-stylesheet branch from 3f71a5b to 3289336 Compare April 20, 2023 14:10
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2750 April 20, 2023 14:10 Inactive
@jon-kirwan jon-kirwan merged commit bef2b03 into main Apr 20, 2023
@jon-kirwan jon-kirwan deleted the remove-unused-page-view-stylesheet branch April 20, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants