[source-linkedin-ads] Lead forms & Lead form responses new streams #52047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kev-datams is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
octavia-squidington-iii
added
area/connectors
kev-datams
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
kev-datams
changed the title
|
hello @natikgadzhi @marcosmarxm, FYI following this previous PR 🙏 |
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
kev-datams
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
…-leads-streams # Conflicts: # airbyte-integrations/connectors/source-linkedin-ads/metadata.yaml # airbyte-integrations/connectors/source-linkedin-ads/pyproject.toml # docs/integrations/sources/linkedin-ads.md
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
kev-datams
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
kev-datams
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
kev-datams
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kev-datams
had a problem deploying
to
community-ci
GitHub Actions
Error
kev-datams
temporarily deployed
to
community-ci
GitHub Actions
Inactive
kev-datams
temporarily deployed
to
community-ci
GitHub Actions
Inactive
kev-datams
temporarily deployed
to
community-ci
GitHub Actions
Inactive
kev-datams
temporarily deployed
to
community-ci
GitHub Actions
Inactive
kev-datams
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
natikgadzhi
approved these changes
Feb 6, 2025
|
I think the CATs are failing because our sandbox does not have the data in the new streams. Can you edit the |
…s' into source-linkedin-ads-leads-streams
auto-merge was automatically disabled
February 6, 2025 20:55
Head branch was pushed to by a user without write access
kev-datams
temporarily deployed
to
community-ci
GitHub Actions
Inactive
kev-datams
temporarily deployed
to
community-ci
GitHub Actions
Inactive
kev-datams
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
@natikgadzhi done ✅ |
|
@DanyloGL can you please test this one? |
marcosmarxm
requested changes
Feb 7, 2025
airbyte-integrations/connectors/source-linkedin-ads/integration_tests/expected_records.jsonl
Outdated
Show resolved
Hide resolved
kev-datams
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kev-datams
temporarily deployed
to
community-ci
GitHub Actions
Inactive
kev-datams
temporarily deployed
to
community-ci
GitHub Actions
Inactive
marcosmarxm
approved these changes
Feb 7, 2025
|
Really nice work @marcosmarxm and @kev-datams. @kev-datams thank you for being so patient with us and so generous with your contributions <3 |
Thank you for reviewing, this is clearly a win-win 🙂 |
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This Pull Request aims in proposing a first version of the
LinkedIn Leadsstreams based on official documentation.It follows this PR adapted for low-code and merged in LinkedIn Ads connector.
How
This PR adds 2 base streams in existing
LinkedIn Adsconnector:The required permission on LinkedIn is
r_marketing_leadgen_automationaccording to this doc bloc.Review guide
Limits & considerationssection)User Impact
User will have access to 2 streams of a new connector.
As explained in the
Limits & considerationssection of the Documentation and due to low-code capabilities limitations:pathIncremental syncis not supported because of specific query param expected by LinkedIn API (eg:submittedAtTimeRange=(start:1711407600000,end:1711494000000))Can this PR be safely reverted and rolled back?