🎉 New Source: LinkedIn Leads #42101

kev-datams · 2024-07-18T14:32:47Z

What

This Pull Request aims in proposing a first version of the LinkedIn Leads source connector based on official documentation.

How

This PR adds 2 base streams:

lead forms
lead form responses

This connector was developed using the low-code development framework.

Schemas of the ingested objects are defined in the schemas/ directory.

Review guide

manifest.yaml
README.md
Documentation (notably the Limits & considerations section)
No particular order after

User Impact

User will have access to 2 streams of a new connector.

As explained in the Limits & considerations section of the Documentation and due to low-code capabilities limitations:

some query params have been hard-coded in the path
Incremental sync is not supported because of specific query param expected by LinkedIn API (eg: submittedAtTimeRange=(start:1711407600000,end:1711494000000))

Also, LinkedIn Ads accounts must be hard-coded in the source connector configuration contrary to the dynamic behavior of LinkedIn Ads source connector. We do consider this spec as acceptable as a first step.

Can this PR be safely reverted and rolled back?

YES 💚
NO ❌ (as soon as it is merged, customers could potentially use it in production)

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1205462189400178

vercel · 2024-07-18T14:32:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Jul 24, 2024 11:59am

kev-datams · 2024-07-18T14:41:15Z

Original discussion: #42042

marcosmarxm

Can you fix the title of your pull request to Source instead of Destination?

kev-datams · 2024-07-18T15:44:12Z

Can you fix the title of your pull request to Source instead of Destination?

Done, sorry for that :)

kev-datams · 2024-07-18T15:45:27Z

Just fix formatting via airbyte-ci format fix all, hope this helps 🙏

natikgadzhi · 2024-08-04T16:05:43Z

airbyte-integrations/connectors/source-linkedin-leads/source_linkedin_leads/manifest.yaml

+            type: DpathExtractor
+            field_path:
+              - elements
+        partition_router:


Is that the same account_id as in linkedin_ads?

@natikgadzhi yes, why ?

natikgadzhi

@FVidalCarneiro this is excellent work, and don't get me wrong — I am EXTREMELY grateful to have this.

I want this merged, alongside your other PRs and ideas. Here's how we can do this:

Make this a new stream in source-linkedin-ads
I left some comments re: possibility of incremental behavior, but it's okay to start with full refresh
schemas should be inline.

natikgadzhi · 2024-08-04T16:06:43Z

airbyte-integrations/connectors/source-linkedin-leads/source_linkedin_leads/manifest.yaml

+    type: object
+    $schema: http://json-schema.org/draft-07/schema#
+    required:
+      - client_id


If leads require new scopes compared to linkedin_ads, this would need to be a breaking change cc @FVidalCarneiro

natikgadzhi · 2024-08-04T16:07:10Z

airbyte-integrations/connectors/source-linkedin-leads/source_linkedin_leads/manifest.yaml

+    lead_form_response: true
+
+schemas:
+  lead_form_response:


This looks incomplete — I would expect schemas to be inline in the yaml manifest, if the connector is made in Builder.

#42101 (comment)

natikgadzhi · 2024-08-04T16:07:26Z

...e-integrations/connectors/source-linkedin-leads/source_linkedin_leads/schemas/lead_form.json

@@ -0,0 +1,284 @@
+{


Don't do separate json schemas, let's put them in the manifest.

@natikgadzhi why do you prefer this way of working with inline schemas ? IMHO, it is more readable to split them in distinct files and not overload the manifest 🤔

natikgadzhi · 2024-08-04T16:08:08Z

...e-integrations/connectors/source-linkedin-leads/source_linkedin_leads/schemas/lead_form.json

+        }
+      }
+    },
+    "created": {


It has created field that looks a lot like a timestamp. Can we use this for incremental sync?

@natikgadzhi we can not, according to the official documentation we can only use submittedAt filtering, and the issue is, as explained, on the way to build the API call submittedAtTimeRange=(start:1711407600000,end:1711494000000) which does not look feasible with low code
https://learn.microsoft.com/en-us/linkedin/marketing/lead-sync/leadsync?view=li-lms-2024-06&tabs=http#get-multiple-lead-form-responses

if you have any workaround suggestion 🙏

kev-datams · 2024-10-24T16:04:37Z

hello @natikgadzhi @marcosmarxm, please coud you reopen the PR ?

Initial release

0129316

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 18, 2024

kev-datams had a problem deploying to community-ci-auto July 18, 2024 14:33 — with GitHub Actions Error

kev-datams had a problem deploying to community-ci July 18, 2024 14:33 — with GitHub Actions Error

kev-datams had a problem deploying to community-ci-auto July 18, 2024 14:33 — with GitHub Actions Error

kev-datams had a problem deploying to community-ci July 18, 2024 14:33 — with GitHub Actions Error

octavia-squidington-iii added community connectors/source/linkedin-ads connectors/source/linkedin-leads labels Jul 18, 2024

kev-datams added 2 commits July 18, 2024 16:33

Remove useless files

78e9a9b

Add PR identifier

34fcb55

kev-datams temporarily deployed to community-ci-auto July 18, 2024 14:36 — with GitHub Actions Inactive

kev-datams had a problem deploying to community-ci July 18, 2024 14:36 — with GitHub Actions Error

kev-datams had a problem deploying to community-ci-auto July 18, 2024 14:36 — with GitHub Actions Failure

vercel bot deployed to Preview July 18, 2024 14:41 View deployment

marcosmarxm requested changes Jul 18, 2024

View reviewed changes

kev-datams changed the title ~~🎉 New Destination: LinkedIn Leads~~ 🎉 New Source: LinkedIn Leads Jul 18, 2024

chore: format code

82a5dd3

kev-datams temporarily deployed to community-ci-auto July 18, 2024 15:45 — with GitHub Actions Inactive

kev-datams had a problem deploying to community-ci July 18, 2024 15:45 — with GitHub Actions Error

fix: properly use JSON defined schemas

3579c30

kev-datams had a problem deploying to community-ci July 24, 2024 11:59 — with GitHub Actions Failure

kev-datams temporarily deployed to community-ci-auto July 24, 2024 11:59 — with GitHub Actions Inactive

kev-datams had a problem deploying to community-ci July 24, 2024 11:59 — with GitHub Actions Failure

kev-datams temporarily deployed to community-ci-auto July 24, 2024 11:59 — with GitHub Actions Inactive

kev-datams requested a review from marcosmarxm July 29, 2024 07:35

natikgadzhi reviewed Aug 4, 2024

View reviewed changes

natikgadzhi requested changes Aug 4, 2024

View reviewed changes

natikgadzhi mentioned this pull request Aug 15, 2024

fix(source-linkedin-ads): revert migration to low code #43359

Merged

2 tasks

octavia-squidington-iii added the Stale label Oct 4, 2024

octavia-squidington-iii closed this Oct 12, 2024

kev-datams mentioned this pull request Jan 21, 2025

[source-linkedin-ads] Lead forms & Lead form responses new streams #52047

Merged

2 tasks

kev-datams deleted the kev-datams/source-linkedin-leads branch January 21, 2025 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: LinkedIn Leads #42101

🎉 New Source: LinkedIn Leads #42101

kev-datams commented Jul 18, 2024 •

edited

Loading

vercel bot commented Jul 18, 2024 •

edited

Loading

kev-datams commented Jul 18, 2024

marcosmarxm left a comment

kev-datams commented Jul 18, 2024

kev-datams commented Jul 18, 2024

natikgadzhi Aug 4, 2024

kev-datams Aug 5, 2024

natikgadzhi left a comment

natikgadzhi Aug 4, 2024

natikgadzhi Aug 4, 2024

kev-datams Aug 5, 2024

natikgadzhi Aug 4, 2024

kev-datams Aug 5, 2024 •

edited

Loading

natikgadzhi Aug 4, 2024

kev-datams Aug 5, 2024

kev-datams commented Oct 24, 2024 •

edited

Loading

🎉 New Source: LinkedIn Leads #42101

🎉 New Source: LinkedIn Leads #42101

Conversation

kev-datams commented Jul 18, 2024 • edited Loading

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

vercel bot commented Jul 18, 2024 • edited Loading

kev-datams commented Jul 18, 2024

marcosmarxm left a comment

Choose a reason for hiding this comment

kev-datams commented Jul 18, 2024

kev-datams commented Jul 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

natikgadzhi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kev-datams Aug 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kev-datams commented Oct 24, 2024 • edited Loading

kev-datams commented Jul 18, 2024 •

edited

Loading

vercel bot commented Jul 18, 2024 •

edited

Loading

kev-datams Aug 5, 2024 •

edited

Loading

kev-datams commented Oct 24, 2024 •

edited

Loading