Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-linkedin-ads] Add schema precisions on Lead Forms and Lead Form responses streams #53611

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kev-datams
Copy link
Contributor

@kev-datams kev-datams commented Feb 10, 2025

What

This pull request aims at fixing the first version of the LinkedIn Leads streams release via this PR with some precisions on data schemas.

How

This PR complements the below streams in existing LinkedIn Ads connector:

  • lead forms: hiddenFields (name & value)
  • lead form responses:
    • leadMetadata (sponsoredLeadMetadata.campaign)
    • associatedEntity (associatedCreative)
    • formResponse (answers, consentReponses)

Review guide

  1. manifest.yaml

User Impact

Have more precise data for destinations, to avoid having all nested data in _airbyte_additional_properties.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Feb 10, 2025

@kev-datams is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Feb 10, 2025
@kev-datams kev-datams changed the title Add schema precisions on Lead Forms and Lead Form responses streams [source-linkedin-ads] Add schema precisions on Lead Forms and Lead Form responses streams Feb 10, 2025
@kev-datams
Copy link
Contributor Author

Hi @natikgadzhi, @marcosmarxm, sorry for this complementary PR, we need for some schema precisions 🙏
Thank you !

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 0:32am

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is a problem with Linkedin credentials used by integration tests. The change looks good. I'll check with connector team and return to you by Wednesday.

@marcosmarxm
Copy link
Member

It seems is a problem with credentials, the auto update pull request failed with same error. @kev-datams I'll monitor when team fix this to get your contribution merged, ask your patience until there. I'll try to give you an update by Monday.

@kev-datams
Copy link
Contributor Author

It seems is a problem with credentials, the auto update pull request failed with same error. @kev-datams I'll monitor when team fix this to get your contribution merged, ask your patience until there. I'll try to give you an update by Monday.

Ok @marcosmarxm thank you for support

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is fine — additive, so even if schemas don't work for some workspaces in prod, we'll hear from them. Unit tests are passing, and most CATs are passing it seems, with some just not having data.

@marcosmarxm
Copy link
Member

@kev-datams can you update your branch?

@kev-datams
Copy link
Contributor Author

@kev-datams can you update your branch?

@marcosmarxm done

@marcosmarxm
Copy link
Member

Still one check test failure... @DanyloGL can you take a look

@natikgadzhi
Copy link
Contributor

@maxi297 this looks good and ready, but I'm not smashing "merge" because you're on call and it's afternoon.

Merge this in the morning? ;)

@kev-datams
Copy link
Contributor Author

Thank you all ! Ready for merging 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/linkedin-ads
Projects
Status: Ready to Ship
Development

Successfully merging this pull request may close these issues.

4 participants