-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[source-linkedin-ads] Add schema precisions on Lead Forms
and Lead Form responses
streams
#53611
base: master
Are you sure you want to change the base?
[source-linkedin-ads] Add schema precisions on Lead Forms
and Lead Form responses
streams
#53611
Conversation
@kev-datams is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
Lead Forms
and Lead Form responses
streams
Hi @natikgadzhi, @marcosmarxm, sorry for this complementary PR, we need for some schema precisions 🙏 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there is a problem with Linkedin credentials used by integration tests. The change looks good. I'll check with connector team and return to you by Wednesday.
It seems is a problem with credentials, the auto update pull request failed with same error. @kev-datams I'll monitor when team fix this to get your contribution merged, ask your patience until there. I'll try to give you an update by Monday. |
Ok @marcosmarxm thank you for support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is fine — additive, so even if schemas don't work for some workspaces in prod, we'll hear from them. Unit tests are passing, and most CATs are passing it seems, with some just not having data.
@kev-datams can you update your branch? |
@marcosmarxm done |
Still one check test failure... @DanyloGL can you take a look |
@maxi297 this looks good and ready, but I'm not smashing "merge" because you're on call and it's afternoon. Merge this in the morning? ;) |
Thank you all ! Ready for merging 🔥 |
What
This pull request aims at fixing the first version of the
LinkedIn Leads
streams release via this PR with some precisions on data schemas.How
This PR complements the below streams in existing
LinkedIn Ads
connector:hiddenFields
(name
&value
)leadMetadata
(sponsoredLeadMetadata.campaign
)associatedEntity
(associatedCreative
)formResponse
(answers
,consentReponses
)Review guide
User Impact
Have more precise data for destinations, to avoid having all nested data in
_airbyte_additional_properties
.Can this PR be safely reverted and rolled back?