Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JDK-Head version number instead of 'jdk' #1764

Closed
wants to merge 1 commit into from

Conversation

M-Davies
Copy link

  • Renames JDK-Next binaries to include the major version number
  • I.e.OpenJDK-jdk_x64_windows_hotspot_2020-03-27-03-31.zip to OpenJDK15U-jdk_x64_windows_hotspot_2020-03-27-03-31.zip
  • Includes various documentation and script updates to allow this to function

Ref: #1016 (Doesn't close it)
Signed-off-by: Morgan Davies [email protected]

@M-Davies
Copy link
Author

OFF SIGHT REQUIREMENTS FOR THIS

@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label May 24, 2020
@karianna karianna added this to the May 2020 milestone May 24, 2020
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies but I landed another doc PR so the release notes have a conflict

@M-Davies M-Davies reopened this May 25, 2020
@M-Davies
Copy link
Author

At this point, all I'm doing is renaming the binary to OpenJDK15u blah blah. Im not touching the actual javaVersion set by the pipeline

@douph1
Copy link
Contributor

douph1 commented May 25, 2020

as discussed here :
#1574

I don't think hard coded JDK-Latest to "15" like already here getJavaVersionNumber() or "15U" a second time is a good idea (maintainability point of view )

If you intended only to fix adoptium/installer#211 here I think I can better handle it in installer script because upstream job always pass the major version number.
So I can search for OpenJDK (without major number) and use it as JDK-Latest = PRODUCT_MAJOR_VERSION and not hardcoded any number either on my side or your side.

@M-Davies
Copy link
Author

@douph1 Yes this was more to fix recent installer failures but if you think you can handle it on the installer side then I would prefer to do that. In addition, 1574 seems to be a better solution to this in the end than this since it avoids extra documentation when JDK-Head gets bumped.

@M-Davies M-Davies closed this May 27, 2020
@karianna karianna added the wontfix Issues that have been deemed as not worth or necessary to fix label May 27, 2020
@M-Davies M-Davies deleted the jdk_head_version branch June 11, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way wontfix Issues that have been deemed as not worth or necessary to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants