Windows JDK15 build pipeline failures

[sxa]

Platform: Windows

Architecture:x64

https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk/job/jdk-windows-x64-hotspot/ has been failing for over a month now

[sxa]

#1764 is an initial proposed fix

[M-Davies]

adoptium/installer#212 is superseeding #1764. @douph1 is looking to implement the fixes on the installer side instead of build

[sxa]

Oddly JDK15/Windows isn't showing in the failed builds today despite the installer job failing, so while this superficially looks ok, it's not.

We seem to have lost the propagation of the error code which was added in https://github.com/AdoptOpenJDK/openjdk-build/pull/1692/files

[douph1]

this is because of this revert db4f158

[sxa]

No it wasn't @douph1 - the PR I referenced was later than the one you mentioned and was intended to fix the problem properly (which is why it's listed as "attempt 2". It has been correctly propogating the error code for the last month since it was merged. The culprit (as identified my Morgan) was seemingly #1755

[M-Davies]

#1782 should set upstream jobs as FAILED if the installer fails

[douph1]

It was because of the commit that I mentioned that added a try / catch.
If the exception hadn't been catch, construction would have failed (I hope)?

[M-Davies]

Resolved as part of many PR's (documented here adoptium/installer#211 (comment))