-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage unzip of JDK-Latest without number in file name #212
Conversation
81d2828
to
e340fa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested changes, but all good overall.
failed ... folder inside archive is "jdk-15+24" Are the 0 always drop ? or the zero drop only if both "minor" and "maintenance" are 0 ? Please don't send me to read the JEP :) (if we conform to it) |
We can definitely have 15.0.1 and 15.1.0 so zero's are not always dropped. I think they might be dropped it's both of them are 0. You can look at the 14 builds to see how the pattern goes... |
look like it is https://openjdk.java.net/jeps/322
but I have not found sample where we have 14.1.0 but I did not find any version with INTERIM incremented with our API |
It's theoretically possible (as in supported by the JEP, and might be used one day) |
Ready to work with artifact OpenJDK_*.zip without major number as we get major java version in job parameter.
All unnumbered (major) zip file is now unzip in a folder "OpenJDK-Latest"
adoptium/temurin-build#1764 is no longer needed for Windows installer.
Fix : adoptium/temurin-build#1712
Need also a revert or fix from adoptium/temurin-build#1754 to return back to normal
This adoptium/temurin-build#1751 is still relevant
and match the JRE|JDK part of #211