New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline feedback doesn't behave correctly on course-only config #87

Closed

oliverfoster opened this issue Mar 9, 2023 · 1 comment · Fixed by #88

Assignees

Labels

Member

oliverfoster commented Mar 9, 2023 •

edited

Loading

Subject of the issue

Currently, if a component is set to inline feedback on the component (not on the course object), it will look like this:

If set to be inline on the course object only, it will look like this:

Behaviour should be normalised.

oliverfoster self-assigned this

oliverfoster added the bug label

oliverfoster added this to adapt_framework: The TODO Board

github-project-automation bot moved this to New in adapt_framework: The TODO Board

oliverfoster moved this from New to Assigned in adapt_framework: The TODO Board

oliverfoster added a commit that referenced this issue


          Fix: Inline feedback normalisation across course and component config (…

7a3bcad

…fixes #87)

oliverfoster mentioned this issue

Fix: Inline feedback normalisation across course and component config (fixes #87) #88

Merged

oliverfoster moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board

oliverfoster closed this as completed in #88

oliverfoster added a commit that referenced this issue


          Fix: Inline feedback normalisation across course and component config (…

f03b1ee

…fixes #87) (#88)

github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board

github-actions bot pushed a commit that referenced this issue


          Chore(release): 4.5.6 [skip ci]

2ca3754

## [4.5.6](v4.5.5...v4.5.6) (2023-04-06)

### Fix

* Inline feedback normalisation across course and component config (fixes #87) (#88) ([f03b1ee](f03b1ee)), closes [#87](#87) [#88](#88)

github-actions bot commented Apr 6, 2023

🎉 This issue has been resolved in version 4.5.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot added the released label

oliverfoster removed this from adapt_framework: The TODO Board

github-actions bot pushed a commit to nagyist/adapt-contrib-tutor that referenced this issue


          Chore(release): 2.2.0 [skip ci]

7679d6a

# [2.2.0](v2.1.2...v2.2.0) (2023-05-27)

### chore

* added package.json ([677347b](677347b))
* added package.json ([94afb62](94afb62)), closes [#3072](https://github.com/nagyist/adapt-contrib-tutor/issues/3072)

### Fix

* _globals schema nesting (adaptlearning#90) ([c385e3c](c385e3c)), closes [adaptlearning#90](https://github.com/nagyist/adapt-contrib-tutor/issues/90)
* Added gitignore for release automation (adaptlearning#77) ([bef3c93](bef3c93)), closes [adaptlearning#77](https://github.com/nagyist/adapt-contrib-tutor/issues/77)
* Added release automation (adaptlearning#73) ([c04b610](c04b610)), closes [adaptlearning#73](https://github.com/nagyist/adapt-contrib-tutor/issues/73)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#82) ([076e8c5](076e8c5)), closes [adaptlearning#82](https://github.com/nagyist/adapt-contrib-tutor/issues/82)
* Check tutor type on page revisit before displaying inline feedback (fixes adaptlearning#91) (adaptlearning#92) ([e4f5761](e4f5761)), closes [adaptlearning#91](https://github.com/nagyist/adapt-contrib-tutor/issues/91) [adaptlearning#92](https://github.com/nagyist/adapt-contrib-tutor/issues/92)
* Framework bumped to v5.22.8 ([8a17aae](8a17aae))
* Inline feedback normalisation across course and component config (fixes adaptlearning#87) (adaptlearning#88) ([f03b1ee](f03b1ee)), closes [adaptlearning#87](https://github.com/nagyist/adapt-contrib-tutor/issues/87) [adaptlearning#88](https://github.com/nagyist/adapt-contrib-tutor/issues/88)
* New style schema added. (adaptlearning#84) ([5be15e0](5be15e0)), closes [adaptlearning#84](https://github.com/nagyist/adapt-contrib-tutor/issues/84)
* Normalizing template icons ([cff3c07](cff3c07))
* replace deprecated a11y_attrs_heading usage (refs adaptlearning#67) (adaptlearning#76) ([f34b5fa](f34b5fa)), closes [adaptlearning#67](https://github.com/nagyist/adapt-contrib-tutor/issues/67) [adaptlearning#76](https://github.com/nagyist/adapt-contrib-tutor/issues/76)
* Stop _id property from directly rendering the _id view (adaptlearning#78) ([df1da66](df1da66)), closes [adaptlearning#78](https://github.com/nagyist/adapt-contrib-tutor/issues/78)
* Version numbers removed from Readme files ([7b6f5bd](7b6f5bd))

### New

* Issue and pr project addition automation (Fixes #3315) ([46f531d](46f531d)), closes [#3315](https://github.com/nagyist/adapt-contrib-tutor/issues/3315)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) ([a666b69](a666b69))

### Update

* `"inline"` feedback restoration (adaptlearning#81) ([f5f35a2](f5f35a2)), closes [adaptlearning#81](https://github.com/nagyist/adapt-contrib-tutor/issues/81)
* Add accessible title (refs adaptlearning#74) (adaptlearning#75) ([bbe81f6](bbe81f6)), closes [adaptlearning#74](https://github.com/nagyist/adapt-contrib-tutor/issues/74) [adaptlearning#75](https://github.com/nagyist/adapt-contrib-tutor/issues/75)
* Switch to model.getFeedback allowing more complex feedback objects (adaptlearning#79) ([25fe47c](25fe47c)), closes [adaptlearning#79](https://github.com/nagyist/adapt-contrib-tutor/issues/79)

### Upgrade

* Bump yaml and semantic-release (adaptlearning#93) ([723a352](723a352)), closes [adaptlearning#93](https://github.com/nagyist/adapt-contrib-tutor/issues/93)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment