New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria-level for headings #67

Closed

StuartNicholls opened this issue Apr 5, 2022 · 1 comment · Fixed by #76

Assignees

Labels

accessibility bug released

StuartNicholls commented Apr 5, 2022

Currently, the aria-level for notify and inline feedback can only be set as one string in the JSON. So if a course has inline feedback and Notify both would render as the same level - level 1 - by default.

Suggest adding an additional global property for inline feedback. Would also need a per component override, to work in a similar way to "_ariaLevel": 1 in adapt.

joe-allen-89 added the bug label

joe-allen-89 added the accessibility label

oliverfoster added this to adapt_framework: The TODO Board

oliverfoster moved this to New in adapt_framework: The TODO Board

chris-steele self-assigned this

chris-steele mentioned this issue

Replace deprecated a11y_attrs_heading usage adaptlearning/adapt-contrib-core#202

Closed

chris-steele added a commit that referenced this issue


          Replace deprecated a11y_attrs_heading usage (fixes #67)

752a16a

oliverfoster mentioned this issue

Fix: replace deprecated a11y_attrs_heading usage (refs #67) #76

Merged

chris-steele added a commit that referenced this issue


          Replace deprecated a11y_attrs_heading usage (fixes #67)

dc325bb

oliverfoster closed this as completed in #76

oliverfoster pushed a commit that referenced this issue


          Fix: replace deprecated a11y_attrs_heading usage (refs #67) (#76)

f34b5fa

Repository owner moved this from New to Needs Releasing in adapt_framework: The TODO Board

github-actions bot pushed a commit that referenced this issue


          Chore(release): 4.2.2 [skip ci]

f6e7f86

## [4.2.2](v4.2.1...v4.2.2) (2022-08-01)

### Fix

* replace deprecated a11y_attrs_heading usage (refs #67) (#76) ([f34b5fa](f34b5fa)), closes [#67](#67) [#76](#76)

github-actions bot commented Aug 1, 2022

🎉 This issue has been resolved in version 4.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot added the released label

oliverfoster removed this from adapt_framework: The TODO Board

github-actions bot pushed a commit to nagyist/adapt-contrib-tutor that referenced this issue


          Chore(release): 2.2.0 [skip ci]

7679d6a

# [2.2.0](v2.1.2...v2.2.0) (2023-05-27)

### chore

* added package.json ([677347b](677347b))
* added package.json ([94afb62](94afb62)), closes [#3072](https://github.com/nagyist/adapt-contrib-tutor/issues/3072)

### Fix

* _globals schema nesting (adaptlearning#90) ([c385e3c](c385e3c)), closes [adaptlearning#90](https://github.com/nagyist/adapt-contrib-tutor/issues/90)
* Added gitignore for release automation (adaptlearning#77) ([bef3c93](bef3c93)), closes [adaptlearning#77](https://github.com/nagyist/adapt-contrib-tutor/issues/77)
* Added release automation (adaptlearning#73) ([c04b610](c04b610)), closes [adaptlearning#73](https://github.com/nagyist/adapt-contrib-tutor/issues/73)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#82) ([076e8c5](076e8c5)), closes [adaptlearning#82](https://github.com/nagyist/adapt-contrib-tutor/issues/82)
* Check tutor type on page revisit before displaying inline feedback (fixes adaptlearning#91) (adaptlearning#92) ([e4f5761](e4f5761)), closes [adaptlearning#91](https://github.com/nagyist/adapt-contrib-tutor/issues/91) [adaptlearning#92](https://github.com/nagyist/adapt-contrib-tutor/issues/92)
* Framework bumped to v5.22.8 ([8a17aae](8a17aae))
* Inline feedback normalisation across course and component config (fixes adaptlearning#87) (adaptlearning#88) ([f03b1ee](f03b1ee)), closes [adaptlearning#87](https://github.com/nagyist/adapt-contrib-tutor/issues/87) [adaptlearning#88](https://github.com/nagyist/adapt-contrib-tutor/issues/88)
* New style schema added. (adaptlearning#84) ([5be15e0](5be15e0)), closes [adaptlearning#84](https://github.com/nagyist/adapt-contrib-tutor/issues/84)
* Normalizing template icons ([cff3c07](cff3c07))
* replace deprecated a11y_attrs_heading usage (refs adaptlearning#67) (adaptlearning#76) ([f34b5fa](f34b5fa)), closes [adaptlearning#67](https://github.com/nagyist/adapt-contrib-tutor/issues/67) [adaptlearning#76](https://github.com/nagyist/adapt-contrib-tutor/issues/76)
* Stop _id property from directly rendering the _id view (adaptlearning#78) ([df1da66](df1da66)), closes [adaptlearning#78](https://github.com/nagyist/adapt-contrib-tutor/issues/78)
* Version numbers removed from Readme files ([7b6f5bd](7b6f5bd))

### New

* Issue and pr project addition automation (Fixes #3315) ([46f531d](46f531d)), closes [#3315](https://github.com/nagyist/adapt-contrib-tutor/issues/3315)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) ([a666b69](a666b69))

### Update

* `"inline"` feedback restoration (adaptlearning#81) ([f5f35a2](f5f35a2)), closes [adaptlearning#81](https://github.com/nagyist/adapt-contrib-tutor/issues/81)
* Add accessible title (refs adaptlearning#74) (adaptlearning#75) ([bbe81f6](bbe81f6)), closes [adaptlearning#74](https://github.com/nagyist/adapt-contrib-tutor/issues/74) [adaptlearning#75](https://github.com/nagyist/adapt-contrib-tutor/issues/75)
* Switch to model.getFeedback allowing more complex feedback objects (adaptlearning#79) ([25fe47c](25fe47c)), closes [adaptlearning#79](https://github.com/nagyist/adapt-contrib-tutor/issues/79)

### Upgrade

* Bump yaml and semantic-release (adaptlearning#93) ([723a352](723a352)), closes [adaptlearning#93](https://github.com/nagyist/adapt-contrib-tutor/issues/93)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment