Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always provide accessible dialog heading #74

Closed
chris-steele opened this issue Jul 27, 2022 · 1 comment
Closed

Always provide accessible dialog heading #74

chris-steele opened this issue Jul 27, 2022 · 1 comment
Assignees
@chris-steele
Labels
accessibility enhancement

Comments

@chris-steele
Copy link
Contributor

Subject of the issue/enhancement/features

If no visual title is required an accessible default should be provided. Related to adaptlearning/adapt-contrib-core#173.

Your environment

  • all framework versions, devices and browsers

Steps to reproduce

Remove _feedback.title, component title and displayTitle and note the absence of a heading for AT.

Expected behaviour

AT should provide the user with a heading for the dialog to describe its purpose.

Actual behaviour

No heading is read out in the absence of a visual title.
@chris-steele chris-steele self-assigned this Jul 27, 2022
This was referenced Jul 27, 2022
Closed
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jul 27, 2022
@oliverfoster
Copy link
Member

oliverfoster commented Jul 27, 2022 •
edited
Loading

I disagree. The default will never be more meaningful than the role=dialog tag. Unless you want to go with just Feedback instead of Alternative Feedback Title, which wouldn't need replacing anywhere near as often.

oliverfoster pushed a commit that referenced this issue Aug 17, 2022
@chris-steele
Update: Add accessible title (refs #74) (#75)
bbe81f6
github-actions bot pushed a commit that referenced this issue Aug 17, 2022
@semantic-release-bot
Chore(release): 4.3.0 [skip ci]
a99d6aa 
# [4.3.0](v4.2.3...v4.3.0) (2022-08-17)

### Update

* Add accessible title (refs #74) (#75) ([bbe81f6](bbe81f6)), closes [#74](#74) [#75](#75)
Repository owner moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Sep 26, 2022
github-actions bot pushed a commit to nagyist/adapt-contrib-tutor that referenced this issue May 27, 2023
@semantic-release-bot
Chore(release): 2.2.0 [skip ci]
7679d6a 
# [2.2.0](v2.1.2...v2.2.0) (2023-05-27)

### chore

* added package.json ([677347b](677347b))
* added package.json ([94afb62](94afb62)), closes [#3072](https://github.com/nagyist/adapt-contrib-tutor/issues/3072)

### Fix

* _globals schema nesting (adaptlearning#90) ([c385e3c](c385e3c)), closes [adaptlearning#90](https://github.com/nagyist/adapt-contrib-tutor/issues/90)
* Added gitignore for release automation (adaptlearning#77) ([bef3c93](bef3c93)), closes [adaptlearning#77](https://github.com/nagyist/adapt-contrib-tutor/issues/77)
* Added release automation (adaptlearning#73) ([c04b610](c04b610)), closes [adaptlearning#73](https://github.com/nagyist/adapt-contrib-tutor/issues/73)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#82) ([076e8c5](076e8c5)), closes [adaptlearning#82](https://github.com/nagyist/adapt-contrib-tutor/issues/82)
* Check tutor type on page revisit before displaying inline feedback (fixes adaptlearning#91) (adaptlearning#92) ([e4f5761](e4f5761)), closes [adaptlearning#91](https://github.com/nagyist/adapt-contrib-tutor/issues/91) [adaptlearning#92](https://github.com/nagyist/adapt-contrib-tutor/issues/92)
* Framework bumped to v5.22.8 ([8a17aae](8a17aae))
* Inline feedback normalisation across course and component config (fixes adaptlearning#87) (adaptlearning#88) ([f03b1ee](f03b1ee)), closes [adaptlearning#87](https://github.com/nagyist/adapt-contrib-tutor/issues/87) [adaptlearning#88](https://github.com/nagyist/adapt-contrib-tutor/issues/88)
* New style schema added. (adaptlearning#84) ([5be15e0](5be15e0)), closes [adaptlearning#84](https://github.com/nagyist/adapt-contrib-tutor/issues/84)
* Normalizing template icons ([cff3c07](cff3c07))
* replace deprecated a11y_attrs_heading usage (refs adaptlearning#67) (adaptlearning#76) ([f34b5fa](f34b5fa)), closes [adaptlearning#67](https://github.com/nagyist/adapt-contrib-tutor/issues/67) [adaptlearning#76](https://github.com/nagyist/adapt-contrib-tutor/issues/76)
* Stop _id property from directly rendering the _id view (adaptlearning#78) ([df1da66](df1da66)), closes [adaptlearning#78](https://github.com/nagyist/adapt-contrib-tutor/issues/78)
* Version numbers removed from Readme files ([7b6f5bd](7b6f5bd))

### New

* Issue and pr project addition automation (Fixes #3315) ([46f531d](46f531d)), closes [#3315](https://github.com/nagyist/adapt-contrib-tutor/issues/3315)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) ([a666b69](a666b69))

### Update

* `"inline"` feedback restoration (adaptlearning#81) ([f5f35a2](f5f35a2)), closes [adaptlearning#81](https://github.com/nagyist/adapt-contrib-tutor/issues/81)
* Add accessible title (refs adaptlearning#74) (adaptlearning#75) ([bbe81f6](bbe81f6)), closes [adaptlearning#74](https://github.com/nagyist/adapt-contrib-tutor/issues/74) [adaptlearning#75](https://github.com/nagyist/adapt-contrib-tutor/issues/75)
* Switch to model.getFeedback allowing more complex feedback objects (adaptlearning#79) ([25fe47c](25fe47c)), closes [adaptlearning#79](https://github.com/nagyist/adapt-contrib-tutor/issues/79)

### Upgrade

* Bump yaml and semantic-release (adaptlearning#93) ([723a352](723a352)), closes [adaptlearning#93](https://github.com/nagyist/adapt-contrib-tutor/issues/93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris-steele chris-steele

Labels
accessibility enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chris-steele @oliverfoster