Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename maximumChi2CutForSeeding #2495

Merged

Conversation

felix-russo
Copy link
Contributor

I renamed maximumChi2CutForSeeding in #2485, which broke the Athena build. Here, I change the variable name back to the original one as discussed in the stand-up meeting.

@felix-russo felix-russo marked this pull request as ready for review October 2, 2023 08:06
@github-actions github-actions bot added Component - Core Affects the Core module Vertexing labels Oct 2, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulgessinger paulgessinger added this to the next milestone Oct 2, 2023
@kodiakhq kodiakhq bot merged commit e349434 into acts-project:main Oct 2, 2023
@github-actions github-actions bot removed the automerge label Oct 2, 2023
@felix-russo felix-russo deleted the rename-maximumChi2CutForSeeding branch October 3, 2023 11:38
@paulgessinger paulgessinger modified the milestones: next, v30.1.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants