refactor: rename local variables and improve comments for IVF #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2485 +/- ##
==========================================
- Coverage 49.85% 49.82% -0.03%
==========================================
Files 466 466
Lines 26248 26246 -2
Branches 12032 12050 +18
==========================================
- Hits 13085 13077 -8
+ Misses 4615 4603 -12
- Partials 8548 8566 +18
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
approved these changes
Sep 29, 2023
acts-project-service
added
the
Breaks Athena build
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
…roject#2485) - Rename some variables - Improve some comments - One little change: Previously `hypotVariance` was set to 1 if it was 0, which seems like a random quick fix. I think it is more correct to skip the track in this case because the expression in line 408 would diverge and the if-condition should evaluate to `false`. 
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
I renamed maximumChi2CutForSeeding in #2485, which broke the Athena build. Here, I change the variable name back to the original one as discussed in the stand-up meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hypotVariancewas set to 1 if it was 0, which seems like a random quick fix. I think it is more correct to skip the track in this case because the expression in line 408 would diverge and the if-condition should evaluate tofalse.