Skip to content

Commit

Permalink
refactor: rename maximumChi2CutForSeeding (#2495)
Browse files Browse the repository at this point in the history
I renamed maximumChi2CutForSeeding in #2485, which broke the Athena build. Here, I change the variable name back to the original one as discussed in the stand-up meeting.
  • Loading branch information
felix-russo authored Oct 2, 2023
1 parent dd3348c commit e349434
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Core/include/Acts/Vertexing/IterativeVertexFinder.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class IterativeVertexFinder {
///
/// are considered compatible with the vertex.
double significanceCutSeeding = 10;
double maximumChi2CutForSeeding = 36.;
double maximumChi2cutForSeeding = 36.;
int maxVertices = 50;

/// Assign a certain fraction of compatible tracks to a different (so-called
Expand Down
2 changes: 1 addition & 1 deletion Core/include/Acts/Vertexing/IterativeVertexFinder.ipp
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ Acts::IterativeVertexFinder<vfitter_t, sfinder_t>::removeUsedCompatibleTracks(

// check if sufficiently compatible with last fitted vertex
// (quite loose constraint)
if (chi2 < m_cfg.maximumChi2CutForSeeding) {
if (chi2 < m_cfg.maximumChi2cutForSeeding) {
auto foundIter =
std::find_if(seedTracks.begin(), seedTracks.end(),
[&trk](const auto seedTrk) { return trk == seedTrk; });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ BOOST_AUTO_TEST_CASE(iterative_finder_test_athena_reference) {
VertexFinder::Config cfg(bFitter, std::move(linearizer), std::move(sFinder),
ipEstimator);
cfg.maxVertices = 200;
cfg.maximumChi2CutForSeeding = 49;
cfg.maximumChi2cutForSeeding = 49;
cfg.significanceCutSeeding = 12;

VertexFinder finder(cfg);
Expand Down

0 comments on commit e349434

Please sign in to comment.