Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file upload validation schema #191

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

ellen-wright
Copy link
Contributor

Description

Moved the file upload validation schema from this PR: UserOfficeProject/user-office-core#531 to the duo-validation package

Motivation and Context

How Has This Been Tested

Fixes

Changes

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

Copy link
Contributor

@martin-trajanovski martin-trajanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellen-wright I have checked this and it looks good to me so far. You need to resolve the merge conflicts as I merged some major update. Also you need to run npm run lerna:prePublish before you push your changes to update the version in the package-lock.json file.

config.required &&
(schema = schema.required('This is a required field').min(1));

config.max_files &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellen-wright I am not sure why do we want to remove the max_files from the check here. Is it removed from the config or?

Copy link
Contributor

@martin-trajanovski martin-trajanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@ellen-wright ellen-wright merged commit 6fd2147 into master Mar 26, 2024
3 checks passed
@ellen-wright ellen-wright deleted the update-file-upload-validation-schema branch March 26, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants