-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update file upload validation schema #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ellen-wright I have checked this and it looks good to me so far. You need to resolve the merge conflicts as I merged some major update. Also you need to run npm run lerna:prePublish
before you push your changes to update the version in the package-lock.json file.
config.required && | ||
(schema = schema.required('This is a required field').min(1)); | ||
|
||
config.max_files && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ellen-wright I am not sure why do we want to remove the max_files
from the check here. Is it removed from the config or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now
Description
Moved the file upload validation schema from this PR: UserOfficeProject/user-office-core#531 to the duo-validation package
Motivation and Context
How Has This Been Tested
Fixes
Changes
Depends on
Tests included/Docs Updated?