-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change file upload error message #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me but as I can see we keep all the validation schemas for the other questions in the @user-office-software/duo-validation
package. Maybe it is a good idea to add this one over there as well.
@martin-trajanovski We seem to have some validations schemas in the repo should these be migrated as well (although out of scope of this issue maybe). |
@ellen-wright yes you are right we should move those over to the duo-validation and keep everything in one place. I also see that for your specific case the validation was in the duo-validation package and I would prefer to keep it there. |
Description
Closes: UserOfficeProject/issue-tracker/issues/663
Motivation and Context
Changes error message when no file is uploaded on required question to be more user friendly.
How Has This Been Tested
Manually and changes added to E2E test.
Fixes
Changes
Added a new file upload validation schema with new error message.
Depends on
Tests included/Docs Updated?