Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change file upload error message #531

Merged
merged 13 commits into from
Mar 27, 2024

Conversation

ellen-wright
Copy link
Contributor

Description

Closes: UserOfficeProject/issue-tracker/issues/663

Motivation and Context

Changes error message when no file is uploaded on required question to be more user friendly.

How Has This Been Tested

Manually and changes added to E2E test.

Fixes

Changes

Added a new file upload validation schema with new error message.

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@ellen-wright ellen-wright requested a review from a team as a code owner February 27, 2024 12:22
@ellen-wright ellen-wright requested review from TCMeldrum and removed request for a team February 27, 2024 12:22
@ellen-wright ellen-wright marked this pull request as draft February 27, 2024 12:22
@ellen-wright ellen-wright marked this pull request as ready for review February 27, 2024 14:01
Copy link
Contributor

@martin-trajanovski martin-trajanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but as I can see we keep all the validation schemas for the other questions in the @user-office-software/duo-validation package. Maybe it is a good idea to add this one over there as well.

@TCMeldrum
Copy link
Contributor

It looks good to me but as I can see we keep all the validation schemas for the other questions in the @user-office-software/duo-validation package. Maybe it is a good idea to add this one over there as well.

@martin-trajanovski We seem to have some validations schemas in the repo should these be migrated as well (although out of scope of this issue maybe).
image

@martin-trajanovski
Copy link
Contributor

It looks good to me but as I can see we keep all the validation schemas for the other questions in the @user-office-software/duo-validation package. Maybe it is a good idea to add this one over there as well.

@martin-trajanovski We seem to have some validations schemas in the repo should these be migrated as well (although out of scope of this issue maybe). image

@ellen-wright yes you are right we should move those over to the duo-validation and keep everything in one place. I also see that for your specific case the validation was in the duo-validation package and I would prefer to keep it there.

@ellen-wright ellen-wright changed the title Change file upload error message fix: Change file upload error message Mar 20, 2024
@bolmsten bolmsten changed the title fix: Change file upload error message Fix: Change file upload error message Mar 21, 2024
@bolmsten bolmsten changed the title Fix: Change file upload error message fix: change file upload error message Mar 21, 2024
@ellen-wright ellen-wright merged commit 64944a2 into develop Mar 27, 2024
20 checks passed
@ellen-wright ellen-wright deleted the 663-change-file-upload-message branch March 27, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File upload doesn't show a friendly message if it fails
4 participants