Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DTFS2-7298): update success banner following moj package fix #3904

Conversation

AlexBramhill
Copy link
Contributor

Introduction ✏️

Due to a now fixed bug in MoJ banner, we had to do a work around to get the padding correct on our success banner.

This now reflects the updated module

@AlexBramhill AlexBramhill self-assigned this Nov 7, 2024
@AlexBramhill AlexBramhill added the Type: chore tech debt label Nov 7, 2024
Copy link
Contributor

@ttbarnes ttbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment - also need to get #3684 merged in first

Copy link

sonarqubecloud bot commented Nov 7, 2024

@ttbarnes ttbarnes changed the title chore(dtfs2-7298): update success banner following moj package fix chore(DTFS2-7298): update success banner following moj package fix Nov 15, 2024
@abhi-markan
Copy link
Contributor

In the interest of keeping PR queue minimal, can we close this PR and add the changes to PR #3684 please.

@ttbarnes
Copy link
Contributor

In the interest of keeping PR queue minimal, can we close this PR and add the changes to PR #3684 please.

I've added the changes here to this PR

Closing this

@ttbarnes ttbarnes closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: chore tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants