Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DTFS2-7531): bump gov design library #3684

Merged
merged 67 commits into from
Dec 3, 2024
Merged

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Oct 15, 2024

Introduction ✏️

This PR updates the govuk-frontend package from 4.8.0 to the latest version, 5.7.1 in all UI microservices:

  • GEF UI
  • Portal UI
  • TFM UI

This is the first PR as part of a series of PRs / changes / improvements we can make with the latest GOV design version.

Resolution ✔️

  • Bump govuk-frontend package.
  • Update all js-enabled scripts to include a conditional govuk-frontend-supported class.
  • Update relevant client side scripts integrity hashes.
  • Update all client side scripts to have type="module".
  • Update express assets, nunjucks config's and SCSS GOV paths.
  • Bump MOJ package.
  • Update service-unavailable CSS.
  • Fix some minor bugs seemingly caused by the GOV design updates (DTFS2-7641, DTFS2-7639, DTFS2-7640, DTFS2-7642).

Miscellaneous ➕

  • Update nunjucks component tests assertions to not check the govuk-button--disabled class, since it has been removed. Instead, check the aria-disabled attribute.
  • Improve the Portal's main index.njk readability, indentation.
  • Update TFM UI's success banner (from this original PR)
  • Update TFM "facility pricing risk" table component to be hard coded instead of using the GOV component.
    • Unfortunately, the existing design cannot be achieved by using the GOV component, we have to hard code it. More details in the DTFS2-7531 jira ticket. Documentation has been added to the nunjucks component.
  • Various conditional/validation rule tweaks.
  • Add missing unit test for a currency validation test.
  • Update/align all "reconciliation" status tags to not be uppercase.

@ttbarnes ttbarnes added the Type: chore tech debt label Oct 15, 2024
@ttbarnes ttbarnes self-assigned this Oct 15, 2024
@ttbarnes ttbarnes merged commit 1e25bba into main Dec 3, 2024
254 of 255 checks passed
@ttbarnes ttbarnes deleted the chore/DTFS2-7531-7535-7539 branch December 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Type: Bug Something isn't working Type: chore tech debt Type: Feature feature Type: Fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants