Banner classes parameter does not work when type parameter is set

[AlexBramhill]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem
  • Followed all applicable steps in the debugging guide
  • Checked the FAQs on the message board for common solutions
  • Checked that your issue doesn't exist: https://github.com/ministryofjustice/moj-frontend/issues
  • Checked that there is not already a package that provides the described functionality

Description

Banner classes do not work if param.type is configured. I assume this is a bug

Steps to Reproduce

1. Create a banner component
2. Add a type:

{{ mojBanner({
  type: 'information',
  html: bannerHtml
}) }}

3. Check type is rendering correctly
4. Add a class

{{ mojBanner({
  type: 'information',
  html: bannerHtml
  classes:'aClassHere'
}) }}

4. Note that the class is not applying correctly
5. Remove the type

{{ mojBanner({
  html: bannerHtml
  classes:'aClassHere'
}) }}

6. Note the class is now rendering correctly

Expected behaviour: [What you expect to happen]
Setting the classes attribute should be independent of the type attribute behaviour.

Actual behaviour: [What happens]
Setting the type attribute means classes can no longer be set

Reproduces how often: [What percentage of the time does it reproduce?]
Every time

Versions

Latest (3.0.0) -- Present for at least 2 years

Additional Information

• Existing implementation appears to have an else and endIf block in a place that disables classes if type is set:

// Existing implementation (spacing added for readability)
<div class=
  "moj-banner
  {% if params.type == 'success' %} moj-banner--success
  {% elif params.type == 'warning' %} moj-banner--warning
  {% else %}           // This else and endIf below cause the bug
  {{- ' ' + params.classes if params.classes}}
  {% endif %}"
  ...
>

• I've raised a PR that includes some refactoring -- The first commit is a simple fix, the latter commit provides a refactor in line with recent button-menu.

• PR for fix here

[gregtyler]

🎉 This issue has been resolved in version 3.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀