Skip to content
This repository has been archived by the owner on Mar 1, 2022. It is now read-only.

Support and/or conjunction for relations #5

Closed
4 tasks done
kirrg001 opened this issue Nov 8, 2018 · 1 comment
Closed
4 tasks done

Support and/or conjunction for relations #5

kirrg001 opened this issue Nov 8, 2018 · 1 comment
Labels
feature

Comments

@kirrg001
Copy link
Contributor

kirrg001 commented Nov 8, 2018 •
edited
Loading

Description

NQL should support and/or conjunctions for relations.

The SQL strategy is currently covered in TryGhost/NQL-old#1

e.g. You can pass a filter into NQL filter=tag:en+tag:de and mongo-knex will receive a mongo JSON object and needs to interpret this object with the help of #4. It has to attach the correct SQL queries.

Tasks

  • support one or some cases for OR conjunction case
  • support one or some cases for AND conjunction case
  • support all cases for OR conjunction
  • support all cases for AND conjunction
@kirrg001 kirrg001 self-assigned this Nov 8, 2018
@kirrg001 kirrg001 mentioned this issue Nov 9, 2018
Merged
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 9, 2018
@kirrg001
Added support for relations: OR conjunction cases
b6a1b87 
refs TryGhost#5
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 9, 2018
@kirrg001
✨ Added support for relations: OR conjunction cases
4f9ac68 
refs TryGhost#5

- supports for many to many relations:
  - tags.slug IN (animal)
  - featured:true AND tags.slug IN (animal)
  - tags.id IN (2,3)
  - tags.id IN (1,2)
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 9, 2018
@kirrg001
✨ Added support for relations: OR conjunction cases
efa4c0a 
refs TryGhost#5

- supports for many to many relations:
  - tags.slug IN (animal)
  - featured:true AND tags.slug IN (animal)
  - tags.id IN (2,3)
  - tags.id IN (1,2)
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 9, 2018
@kirrg001
✨ Added support for relations: OR conjunction cases
1833c4f 
refs TryGhost#5

- supports for many to many relations:
  - tags.slug IN (animal)
  - featured:true AND tags.slug IN (animal)
  - tags.id IN (2,3)
  - tags.id IN (1,2)
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 9, 2018
@kirrg001
✨ Added support for relations: OR conjunction cases
edd26b8 
refs TryGhost#5

- supports for many to many relations:
  - tags.slug IN (animal)
  - featured:true AND tags.slug IN (animal)
  - tags.id IN (2,3)
  - tags.id IN (1,2)
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 9, 2018
@kirrg001
✨ Added support for relations: OR conjunction cases
0f4b1f3 
refs TryGhost#5

- supports for many to many relations:
  - tags.slug IN (animal)
  - featured:true AND tags.slug IN (animal)
  - tags.id IN (2,3)
  - tags.id IN (1,2)
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 9, 2018
@kirrg001
✨ Added support for relations: OR conjunction cases
dd87a8f 
refs TryGhost#5

- supports for many to many relations:
  - tags.slug IN (animal)
  - featured:true AND tags.slug IN (animal)
  - tags.id IN (2,3)
  - tags.id IN (1,2)
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 9, 2018
@kirrg001
✨ Added support for relations: OR conjunction cases
d677cf9 
refs TryGhost#5

- supports for many to many relations:
  - tags.slug IN (animal)
  - featured:true AND tags.slug IN (animal)
  - tags.id IN (2,3)
  - tags.id IN (1,2)
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 9, 2018
@kirrg001
✨ Added support for relations: OR conjunction cases
1f23ecd 
refs TryGhost#5

- supports for many to many relations:
  - tags.slug IN (animal)
  - featured:true AND tags.slug IN (animal)
  - tags.id IN (2,3)
kirrg001 added a commit that referenced this issue Nov 13, 2018
@kirrg001
✨Added support for relations: OR conjunction cases (#12)
055ecce 
refs #5

- supports for many to many relations:
  - tags.slug IN (animal)
  - featured:true AND tags.slug IN (animal)
  - tags.id IN (2,3)
@kirrg001 kirrg001 removed their assignment Nov 13, 2018
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 15, 2018
@kirrg001
✨ Added support for 1 and conjunction case
8952b48 
refs TryGhost#5

- $and: [tags.slug:en, tags.slug:de]
@kirrg001 kirrg001 mentioned this issue Nov 15, 2018
Merged
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 15, 2018
@kirrg001
✨ Added support for 1 and conjunction case
ba08db0 
refs TryGhost#5

- $and: [tags.slug:en, tags.slug:de]
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 15, 2018
@kirrg001
✨ Added support for 1 and conjunction case
e80f879 
refs TryGhost#5

- $and: [tags.slug:en, tags.slug:de]
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 15, 2018
@kirrg001
✨ Added support for one $and conjunction case
811e4e6 
refs TryGhost#5

- $and: [tags.slug:en, tags.slug:de]
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 15, 2018
@kirrg001
Added another $and conjunction case
8de25b0 
refs TryGhost#5

- $and: [{'tags.slug': 'animal'},{'tags.slug': {$nin: ['classic']}}]
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 16, 2018
@kirrg001
Added more cases for $or and $and conjunctions
7ade39b 
refs TryGhost#5, refs TryGhost#7

- (tags.slug = animal and sort_order = 0) OR visibility:internal (group)
- tags.slug = animal OR sort_order = 0 OR visibility:internal
- (tags.slug is animal and sort_order is 0) and tags.visibility=public (group)
- tags.slug is animal and sort_order is 0 and tags.visibility=public
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 16, 2018
@kirrg001
✨ Added another $and conjunction case
444caad 
refs TryGhost#5

- $and: [{'tags.slug': 'animal'},{'tags.slug': {$nin: ['classic']}}]
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 16, 2018
@kirrg001
✨ Added more cases for $or and $and conjunctions
5e01641 
refs TryGhost#5, refs TryGhost#7

- (tags.slug = animal and sort_order = 0) OR visibility:internal (group)
- tags.slug = animal OR sort_order = 0 OR visibility:internal
- (tags.slug is animal and sort_order is 0) and tags.visibility=public (group)
- tags.slug is animal and sort_order is 0 and tags.visibility=public
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 16, 2018
@kirrg001
✨ Added support for one $and conjunction case
235445e 
refs TryGhost#5

- $and: [tags.slug:en, tags.slug:de]
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 16, 2018
@kirrg001
✨ Added another $and conjunction case
59a67f2 
refs TryGhost#5

- $and: [{'tags.slug': 'animal'},{'tags.slug': {$nin: ['classic']}}]
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 16, 2018
@kirrg001
✨ Added more cases for $or and $and conjunctions
d0d8ffa 
refs TryGhost#5, refs TryGhost#7

- (tags.slug = animal and sort_order = 0) OR visibility:internal (group)
- tags.slug = animal OR sort_order = 0 OR visibility:internal
- (tags.slug is animal and sort_order is 0) and tags.visibility=public (group)
- tags.slug is animal and sort_order is 0 and tags.visibility=public
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 16, 2018
@kirrg001
🎨 Added another $and conjunction case
cf5334a 
refs TryGhost#5

- $and: [{'tags.slug': 'animal'},{'tags.slug': {$nin: ['classic']}}]
kirrg001 added a commit to kirrg001/mongo-knex that referenced this issue Nov 16, 2018
@kirrg001
🎨 Added more cases for $or and $and conjunctions
12aada3 
refs TryGhost#5, refs TryGhost#7

- (tags.slug = animal and sort_order = 0) OR visibility:internal (group)
- tags.slug = animal OR sort_order = 0 OR visibility:internal
- (tags.slug is animal and sort_order is 0) and tags.visibility=public (group)
- tags.slug is animal and sort_order is 0 and tags.visibility=public
kirrg001 added a commit that referenced this issue Nov 16, 2018
@kirrg001
✨ Added support for one $and conjunction case
e32cb21 
refs #5

- $and: [tags.slug:en, tags.slug:de]
kirrg001 added a commit that referenced this issue Nov 16, 2018
@kirrg001
🎨 Added another $and conjunction case
30c1fb5 
refs #5

- $and: [{'tags.slug': 'animal'},{'tags.slug': {$nin: ['classic']}}]
kirrg001 added a commit that referenced this issue Nov 16, 2018
@kirrg001
🎨 Added more cases for $or and $and conjunctions
8b6a12f 
refs #5, refs #7

- (tags.slug = animal and sort_order = 0) OR visibility:internal (group)
- tags.slug = animal OR sort_order = 0 OR visibility:internal
- (tags.slug is animal and sort_order is 0) and tags.visibility=public (group)
- tags.slug is animal and sort_order is 0 and tags.visibility=public
@naz naz mentioned this issue Nov 21, 2018
Merged
naz added a commit that referenced this issue Dec 4, 2018
@naz
🎨 Added support for negation and conjunctions on join table in M:M re…
677b0a3 
…lations (#18)

refs #5
refs #7

- Improved group comparison operator check
- Improved negation handling in conjunctions that have conditions on the connecting table
- Added test cases where one of the properties is negated
- Added support for negation inside $and conjunction with joining table condition
@kirrg001
Copy link
Contributor Author

kirrg001 commented Dec 4, 2018

We just merged #18, which supports a couple of more cases for $and and $or conjunction.

I am closing this issue for now. If we discover new cases which are not covered, we just raise a new issue 👍

@kirrg001 kirrg001 closed this as completed Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirrg001