This repository has been archived by the owner on Mar 1, 2022. It is now read-only.
Added support for one $and conjunction case and one negation case (relations) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
changed the title
kirrg001
commented
Nov 15, 2018
11 tasks
kirrg001
changed the title
kirrg001
force-pushed
the
and-conj
branch
2 times, most recently
from
c0d3209 to
4a67b37
Compare
kirrg001
changed the title
|
@gargol I tried to refactor the logic, but it's tricky, because there are so many cases. I'd suggest to just leave this as is and add more use cases. |
kirrg001
changed the title
|
@gargol Ready for review. If you merge, please merge all commits into master. |
kirrg001
commented
Nov 16, 2018
refs TryGhost#5 - $and: [tags.slug:en, tags.slug:de]
refs TryGhost#7 - `tags.slug:-animal`
refs TryGhost#5 - $and: [{'tags.slug': 'animal'},{'tags.slug': {$nin: ['classic']}}]
no issue
refs TryGhost#5, refs TryGhost#7 - (tags.slug = animal and sort_order = 0) OR visibility:internal (group) - tags.slug = animal OR sort_order = 0 OR visibility:internal - (tags.slug is animal and sort_order is 0) and tags.visibility=public (group) - tags.slug is animal and sort_order is 0 and tags.visibility=public
no issue
no issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #5
$and: [tags.slug:en, tags.slug:de]$and: [{'tags.slug': 'animal'},{'tags.slug': {$nin: ['classic']}}]refs #7
tags.slug:-animalAnd some more 👻