Support for negation and conjunctions on join table in M:M relation #18

naz · 2018-11-21T19:45:48Z

refs #5
refs #7

This was an attempt to expand existing conjunctions but ended up as a cleanup and extension of existing test cases. The main operation that was missing and has been added is negation and conjunctions support that used joining table in it's filter, e.g:

{
        {
            $and: [
                {
                    'tags.slug': {
                        $ne: 'classic'
                    }
                },
                {
                    'posts_tags.sort_order': 0
                }
            ]
        },
        {
            featured: true
        }
    ]
}

The rest of M:M cases now seems to be covered.

naz · 2018-11-27T18:45:04Z

lib/convertor.js

@@ -47,10 +48,9 @@ class MongoToKnex {
     * Determine if statement lives on parent table or if statement refers to a relation.
     */
    processStatement(column, op, value) {
-        const columnParts = column.split('.');
-
+        const [tableName, columnName] = column.split('.');


Improved the naming a bit as it was hard to see right away what columnParts[0] and columnParts[1] actually mean

This is an obvious improvement to me - I would just push this commit (and any like it) right onto master.

Same goes for all the stuff that's just rejigging tests on its own without any related code changes.

lib/convertor.js

test/integration/relations.test.js

naz · 2018-11-27T19:00:32Z

test/integration/relations.test.js

+                return query
+                    .select()
+                    .then((result) => {
+                        // TODO: should this include tags with no tags? the filter is about primary tag != 'classic' so they should count?


needs clarification 🤷‍♂️ but seems correct

Tag with no tags?

tags with no tags!!! and posts without posts!!!

test/integration/relations.test.js

naz · 2018-11-28T00:05:16Z

@ErisDS if you have time today would love to receive some feedback on this PR. Didn't reorganise the commits, left comments instead :)

lib/convertor.js

…nnecting table

… condition

lib/convertor.js

ErisDS · 2018-11-29T12:54:18Z

lib/convertor.js

@@ -96,7 +96,7 @@ class MongoToKnex {
            };
        }

-        // CASE: fallback, `status=draft` -> `posts.status`=draft
+        // CASE: fallback, `status=drat` -> `posts.status`=draft


ErisDS · 2018-11-29T13:00:42Z

This all looks good to me - I can see what the changes are intended to accomplish and it all makes sense.

🚢 and continue!

naz changed the title ~~[WIP] Test suite for many-to-many relations cleanup and expansion~~ [WIP] Support for negation and conjunctions on join table in M:M relation Nov 27, 2018