React #912
React #912
Conversation
package.json
Outdated
| "exports-loader": "^0.7.0", | ||
| "expose-loader": "^0.7.5", | ||
| "faker": "~4.1.0", | ||
| "firebase": "^3.9.0", |
There was a problem hiding this comment.
Let's add this back to master in a separate PR.
There was a problem hiding this comment.
I'm trying to make this run with start:prod. It's finally going well when removing some pieces here. But I'd like to understand what I'm breaking by removing these pieces.
@nicksellen I'd appreciate a feedback.
config/webpack/entries/main.js
Outdated
| r.keys().forEach(path => { | ||
| const Component = r(path).default; | ||
| const name = extractComponentNameFromPath(path); | ||
| if (name !== Component.name) { |
There was a problem hiding this comment.
What is the motivation for this check @nicksellen? The application running via start:prod fails here and the check doesn't seem to be required. Maybe we could disable this in production env?
| const photo = photos[name]; | ||
| const file = (window.innerWidth <= 480 && photo.file_mobile) ? photo.file_mobile : photo.file; | ||
| const imageUrl = `/img/board/${file}`; | ||
| getApplicationScope().$emit('photoCreditsUpdated', { [name]: photo }); |
There was a problem hiding this comment.
What is the motivation for having this @nicksellen? It doesn't seem to be required for the application to function and the application fails when it's run with start:prod script.
(I also changed the ng-annotate-loader in config/webpack/webpack.config.js to babel-plugin-angularjs-annotate, so maybe these two fail when together.)
This was recently removed when AddThis script was removed with invite-page.
to be part of the angularjs component, not to replace it
also - add react version to .eslintrc - make dependency versioning in package.json consistent (^ => ~)
|
Merged. Happy React! |
|
Happy React to everyone! 🎉 Huge kudos to both @mrkvon @nicksellen 👏 Nicely done! |
Continuation of #790 after #911
npm run build:prodbroke #910Nice to have merged before this: #913