Revert "Add React and an example component" #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b14f46a.
simison
reviewed
Dec 4, 2018
| "exports-loader": "^0.7.0", | ||
| "expose-loader": "^0.7.5", | ||
| "faker": "~4.1.0", | ||
| "firebase": "^3.9.0", |
There was a problem hiding this comment.
just noting that this looks a bit off (firebase should be unrelated to this change), but might've been in original PR as well. I remember fixing having this in both devDependencies and dependencies
guaka
force-pushed
the
revert-790-react
branch
from
f571973 to
4ed76c9
Compare
|
|
Merged
|
Just confirmed that this was removed Let's loop back to add it there again. cc @mrkvon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #790